EIP-7002:Execution layer triggerable withdrawals #14031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
changed the title
| if isFullExitRequest { | ||
| //# Only exit validator if it has no pending withdrawals in the queue | ||
| if pendingBalanceToWithdraw == 0 { | ||
| maxExitEpoch, churn := validators.MaxExitEpochAndChurn(st) |
There was a problem hiding this comment.
Could be defined outside of the for loop
There was a problem hiding this comment.
I don't think so, if there are multiple values the loop updates the state I think
saolyn
reviewed
May 28, 2024
Co-authored-by: Sammy Rosso <[email protected]>
Co-authored-by: Sammy Rosso <[email protected]>
Co-authored-by: Sammy Rosso <[email protected]>
rkapka
reviewed
May 29, 2024
|
|
||
| vIdx, exists := st.ValidatorIndexByPubkey(bytesutil.ToBytes48(wr.ValidatorPubkey)) | ||
| if !exists { | ||
| log.Debugln("Skipping execution layer withdrawal request, validator index not found") |
There was a problem hiding this comment.
What's the difference between Debug and Debugln?
There was a problem hiding this comment.
hmm not sure i used debugln since i know it adds a new line not sure if debug also does
| @@ -75,6 +86,107 @@ import ( | |||
| // withdrawable_epoch=withdrawable_epoch, | |||
| // )) | |||
| func ProcessExecutionLayerWithdrawRequests(ctx context.Context, st state.BeaconState, wrs []*enginev1.ExecutionLayerWithdrawalRequest) (state.BeaconState, error) { | |||
There was a problem hiding this comment.
In the spec the function is called process_execution_layer_withdrawal_request (Withdraw --> Withdrawal). The parameter also has Withdrawal in the name,
Co-authored-by: Radosław Kapka <[email protected]>
rkapka
approved these changes
May 30, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
implements https://eips.ethereum.org/EIPS/eip-7002 with changes described in https://github.com/ethereum/consensus-specs/blob/dev/specs/electra/beacon-chain.md
Which issues(s) does this PR fix?
Fixes #
Other notes for review