Prysmctl ui bug #14140
Merged
Prysmctl ui bug #14140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
previously approved these changes
Jun 25, 2024
james-prysm
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
This PR solves a bug to the prysmctl ui where given a list of 20 or more validators the user would be unable to scroll through and select the validators to exit.
This was due to setting a dynamic size of
len(pubKeyStrings)in thepromptui.Selectstatement which set the window size for the interactive selection. This meant that when someone had over 20 keys, the window would be so large that the scrolling would break.Fixing the window size to 10 items solves the problem on all affected versions of prysm (v5+).
Which issues(s) does this PR fix?
Fixes #14092
Other notes for review