EIP-7549: Allow multiple committee bits #14203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
added
Ready For Review
saolyn
reviewed
Jul 11, 2024
Comment on lines
-55
to
-61
| t.Run("data source Electra - multiple bits set", func(t *testing.T) { | ||
| cb := primitives.NewAttestationCommitteeBits() | ||
| cb.SetBitAt(0, true) | ||
| cb.SetBitAt(1, true) | ||
| att := util.HydrateAttestationElectra(ðpb.AttestationElectra{CommitteeBits: cb}) | ||
| _, err := attestation.NewId(att, attestation.Data) | ||
| assert.ErrorContains(t, "2 committee bits are set", err) |
There was a problem hiding this comment.
Should we not keep this test?
There was a problem hiding this comment.
no because this asserts that setting 2 committee bits is wrong, while this PR allows it
saolyn
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
This PR fixes tests failing with
could not create attestation IDin #14180.We need to allow more than 1 committee bit set when creating an attestation ID because when we prune attestations we create IDs based on what we see in a block. And an Electra block will have aggregated attestations with more than 1 committee bit.