Handle Skipped Slots in Sync #1939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
added
Bug
nisdas
requested review from
rauljordan,
0xKiwi,
prestonvanloon and
terencechain
Codecov Report
@@ Coverage Diff @@
## master #1939 +/- ##
==========================================
- Coverage 72.08% 71.84% -0.25%
==========================================
Files 106 106
Lines 8038 7916 -122
==========================================
- Hits 5794 5687 -107
+ Misses 1720 1711 -9
+ Partials 524 518 -6 |
terencechain
reviewed
Mar 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Write why you are making the changes in this pull request.
This PR is to allow us to handle skipped slots in initial sync.
Write a summary of the changes you are making.