Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename coinbase to fee recipient #9918

Merged
merged 9 commits into from
Nov 23, 2021
Merged

Rename coinbase to fee recipient #9918

merged 9 commits into from
Nov 23, 2021

Conversation

terencechain
Copy link
Member

Rename coinbase to fee recipient as specified in ethereum/consensus-specs#2728

@terencechain terencechain requested a review from a team as a code owner November 18, 2021 17:11
prestonvanloon
prestonvanloon previously approved these changes Nov 18, 2021
View reviewed changes
Copy link
Member

@prestonvanloon prestonvanloon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Fee recipient is more intuitive than coinbase, are EL clients making this change as well?

@terencechain
Copy link
Member Author

terencechain commented Nov 18, 2021 •
edited
Loading

LGTM

Fee recipient is more intuitive than coinbase, are EL clients making this change as well?

The engine API is making the change, but im not sure about the actual EL clients themselves: https://github.com/ethereum/execution-apis/pull/130/files

@terencechain terencechain self-assigned this Nov 18, 2021
@terencechain terencechain added the Merge PRs related to the great milestone the merge label Nov 18, 2021
@prestonvanloon prestonvanloon mentioned this pull request Nov 19, 2021
Closed
@prylabs-bulldozer prylabs-bulldozer bot merged commit cd1e3f2 into develop Nov 23, 2021
@delete-merged-branch delete-merged-branch bot deleted the fee-recipient branch November 23, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauljordan rauljordan rauljordan approved these changes

@prestonvanloon prestonvanloon prestonvanloon left review comments

@potuz potuz Awaiting requested review from potuz potuz is a code owner automatically assigned from prysmaticlabs/core-team

@james-prysm james-prysm Awaiting requested review from james-prysm james-prysm is a code owner automatically assigned from prysmaticlabs/core-team

@uncdr uncdr Awaiting requested review from uncdr uncdr is a code owner automatically assigned from prysmaticlabs/core-team

Assignees

@terencechain terencechain

Labels
Merge PRs related to the great milestone the merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@terencechain @rauljordan @prestonvanloon