completely removed major service filtering because there are bluetoot… #615
+1
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h speakers that do this wrong. Without this filtering, the user will be presented with a list of ALL bluetooth devices. They will have to know which ones to select. The current device I am connecting to uses COD 0x414. This is being filtered out by the current implementation is for rendering only. At a minimum, the filtering should be looking at: ESP_BT_COD_SRVC_RENDERING ESP_BT_COD_SRVC_AUDIO ESP_BT_COD_SRVC_TELEPHONY
|
This is a bit too generic and could break currently working code. Anyhow, I am not aware of any issues where a valid speaker would show up as In the log... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
completely removed major service filtering because there are bluetooth speakers that do this wrong. Without this filtering, the user will be presented with a list of ALL bluetooth devices. They will have to know which ones to select. The current bluetooth speaker I am connecting to COD 0x414. This is being filtered out by the current implementation. Secondly, there are other major services that should have been included in the filter. At a minimum, the filtering should be looking at:
ESP_BT_COD_SRVC_RENDERING
ESP_BT_COD_SRVC_AUDIO
ESP_BT_COD_SRVC_TELEPHONY
Since there is no guarantee to other Bluetooth devices will do this correctly, why filter out devices that could be compatible, but are just reporting out the COD incorrectly. I know you have had a lot of reports of speakers not showing up that should have...