Skip to content

Commit

Permalink
Move 3.11 tests to install aiohttp without C extensions (#3258)
Browse files Browse the repository at this point in the history
* Move 311 tests to install aiohttp without C extensions

- Configure tox to install aiohttp without extensions
  - i.e. use `AIOHTTP_NO_EXTENSIONS=1` for pip install
  - This allows us to reenable blackd tests that use aiohttp testing helpers etc.
- Had to ignore `cgi` module deprecation warning
  - Filed issue for aiohttp to fix: aio-libs/aiohttp#6905

Test:
- `/tmp/tb/bin/tox -e 311`

* Fix formatting + linting

* Add latest aiohttp for loop fix + Try to exempt deprecation warning but failed - will ask for help

* Remove unnecessary warning ignore

Co-authored-by: Cooper Ry Lees <[email protected]>
Co-authored-by: Richard Si <[email protected]>
  • Loading branch information
3 people committed Sep 5, 2022
1 parent 062e644 commit 383b228
Show file tree
Hide file tree
Showing 4 changed files with 203 additions and 199 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test-311.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Partially test 3.11 dev
name: Test 3.11 without aiohttp extensions

on:
push:
Expand Down
3 changes: 3 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -111,4 +111,7 @@ filterwarnings = [
# this is mitigated by https://github.com/python/cpython/issues/79071 in python 3.8+
# this ignore can be removed when support for 3.7 is dropped.
'''ignore:Bare functions are deprecated, use async ones:DeprecationWarning''',
# aiohttp is using deprecated cgi modules - Safe to remove when fixed:
# https://github.com/aio-libs/aiohttp/issues/6905
'''ignore:'cgi' is deprecated and slated for removal in Python 3.13:DeprecationWarning''',
]
Loading

0 comments on commit 383b228

Please sign in to comment.