Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Github Action] Directly install from repo. if export-subst is skipped #4313

Merged
merged 3 commits into from
Apr 24, 2024
Merged

[Github Action] Directly install from repo. if export-subst is skipped #4313

merged 3 commits into from
Apr 24, 2024

Conversation

EarlMilktea
Copy link
Contributor

@EarlMilktea EarlMilktea commented Apr 17, 2024

Description

I noticed that, if the github action is called in an unexpected way (such as from https://github.com/nektos/act), substitution of .git_archival.txt can be skipped.
For that cases, the action tries to execute pip install black[colorama]==$Format:%(describe:tags=true,match=*[0-9]*)$, which is not making any sense.
This PR is trying to fix this behavior.

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

@EarlMilktea EarlMilktea marked this pull request as ready for review April 17, 2024 19:24
@EarlMilktea EarlMilktea changed the title Directly install from repo. if export-subst is omitted Directly install from repo. if export-subst is skipped Apr 17, 2024
@EarlMilktea EarlMilktea changed the title Directly install from repo. if export-subst is skipped [Github Action] Directly install from repo. if export-subst is skipped Apr 23, 2024
@JelleZijlstra JelleZijlstra merged commit 2f88085 into psf:main Apr 24, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants