Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off pre-commit's automatic parallelization for black #675

Merged
merged 1 commit into from
Jan 18, 2019
Merged

Turn off pre-commit's automatic parallelization for black #675

merged 1 commit into from
Jan 18, 2019

Conversation

asottile
Copy link
Contributor

black internally uses multiprocessing for speed. In pre-commit 1.13.0 this is automated by the framework itself however if both pre-commit and black are forking processes this is slower and hits race-conditions in black.

black internally uses multiprocessing for speed.  In pre-commit 1.13.0 this is automated by the framework itself however if both pre-commit and black are forking processes this is slower and hits race-conditions in `black`.
@coveralls
Copy link

coveralls commented Jan 18, 2019

Pull Request Test Coverage Report for Build 868

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.65%

Totals Coverage Status
Change from base Build 865: 0.0%
Covered Lines: 2788
Relevant Lines: 3042

💛 - Coveralls

@zsol zsol merged commit bc7e5c9 into psf:master Jan 18, 2019
@zsol
Copy link
Collaborator

zsol commented Jan 18, 2019

Thanks!

@asottile asottile deleted the patch-1 branch January 18, 2019 21:00
@asottile
Copy link
Contributor Author

asottile commented Jan 18, 2019

@zsol mind taking a look at #674 (oops had the wrong number here) as well? it's related :D

@zsol
Copy link
Collaborator

zsol commented Jan 20, 2019

I did actually, just didn't have a chance to play around with it. Anyway I saw Jelle already merged it. Thanks for that, too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants