Fix the max_mem_rss measurement #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
reviewed
Jun 12, 2024
| if resource is not None: | ||
| usage = resource.getrusage(resource.RUSAGE_CHILDREN) | ||
| if resource_type is None: | ||
| resource_type = resource.RUSAGE_CHILDREN |
There was a problem hiding this comment.
We should not use RUSAGE_SELF on Linux, FreeBSD and other platforms?
There was a problem hiding this comment.
This function is called in two contexts -- one when the benchmark runs entirely in a separate subprocess, in which case we want CHILDREN, and one when in which it runs in the same process, where we want SELF. Saying that, it would probably clearer to not have a default value for resource_type here.
vstinner
reviewed
Jun 12, 2024
pyperf/_process_time.py
Outdated
| @@ -61,7 +61,7 @@ def bench_process(loops, args, kw, profile_filename=None): | |||
| args = [args[0], "-m", "cProfile", "-o", temp_profile_filename] + args[1:] | |||
|
|
|||
| for _ in range_it: | |||
| start_rss = get_max_rss() | |||
| start_rss = get_max_rss(resource.RUSAGE_CHILDREN) | |||
There was a problem hiding this comment.
resource.RUSAGE_CHILDREN doesn't work on Windows: resource module is not available there.
You should add an abstraction, like having a children=True parameter for get_max_rss().
vstinner
reviewed
Jun 12, 2024
Co-authored-by: Victor Stinner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In c960443, which fixed a bug in scaling the
mem_max_rssvalue on Darwin, I inadvertently changed the measurement from usingRUSAGE_SELFtoRUSAGE_CHILDREN. This has resulted in the measurements being much coarser and incorrect on Darwin. This reverts to the old correct behavior.