Collection support

[dantleech]

Support for storing collections.

For example:

Mapping:

    'mapping' => [
        Article::class => [
            'properties' => [
                'title' => [
                    'type' => 'text',
                ],
                'slideshow' => [
                    'type' => 'collection',
                ]
            ],
        ],


```php
$article = new Article();
$article->title = 'Hello World';
$article->slideshow = [ $image1, $image2, $image3 ];

$dm->persist($article);
$dm->flush();

| cmfct:slideshow-0    | nt:unstructured |                                                                             |
| | height             | LONG (3)        | 200                                                                         |
| | mimetype           | STRING (10)     | image/jpeg                                                                  |
| | path               | STRING (15)     | /path/to/image1                                                             |
| | width              | LONG (3)        | 100                                                                         |
| cmfct:slideshow-1    | nt:unstructured |                                                                             |
| | height             | LONG (3)        | 200                                                                         |
| | mimetype           | STRING (10)     | image/jpeg                                                                  |
| | path               | STRING (15)     | /path/to/image2                                                             |
| | width              | LONG (3)        | 100                                                                         |
| cmfct:slideshow-2    | nt:unstructured |                                                                             |
| : height             | LONG (3)        | 200                                                                         |
| : mimetype           | STRING (10)     | image/jpeg                                                                  |
| : path               | STRING (15)     | /path/to/image3                                                             |
| : width              | LONG (3)        | 100                                                                         |
| title                | STRING (5)      | Hello                                                                       |

[dantleech]

use constant.

[dantleech]

Missing doc

[dantleech]

This is failing with SF 2.8 because of the Form changes.

In this PR we instantiate the form type (via a form extension) based on the model, e.g. $formFactory->get(MyContent::class) - it then returns a SurrogateType" This works fine on 3.0, but not in 2.8.

I thought about adding some BC hacks of our own, but then it is going to be some months (years?) before this is stable and 3.0 is already out.

I think we should pin this at 3.0. wdyt @wouterj @dbu ?

[dbu]

this is a new library, lets not bother with symfony 2 if its an obstacle.

[wouterj]

2.8 should behave exactly the same as 3.0, can you please show where we need BC hacks here?

[dantleech]

@wouterj it is because of the BC hacks in 2.8. In 3.0 the extension is directly responsible for providing the form, and it can therefore return any type, in this case a SurrogateType which is a "dynamic" form type.

In 2.8 this is not possible.. Afraid I havn't got much time to look into it and remember exactly why now. But will try and have a look before merging this.

[dantleech]

@wouterj it is because the 2.8 system uses the class name of the object returned by the extension as the "type name". In this case that object is always of type SurrogateType.

The 3.* series will use the given name as the "form type", in this case Post::class, which means that when requesting a form for Post::class we will reveive a SurrogateType which is ready to add the fields configured for the Post::class as mapped in the content-type component.

In 2.8 we would never find a form type for Post::class as they would be regstered under SurrogateType "form name".

3.x allows us to request a form type for "X" and it doesn't matter what "X" is, and it doesn't matter what the form type is. In our case it can be dynamic and primed with the metadata for "X".

Does that sound OK?

/cc @webmozart

[wouterj]

typo $surrogteType

[dantleech]

Merging this now -- as for the method used to resolve the form type, I am not even sure it is the best solution, it might ultimately be better to have a dedicated form factory here at the cost of not being able to seamlessly integrate with things like the Sylius resource bundle. But lets see how things pan out.