Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing psptypes.h #246

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Add missing psptypes.h #246

merged 2 commits into from
Oct 31, 2024

Conversation

wally4000
Copy link
Contributor

u8 type is not declared in pspwlan.h

@sharkwouter
Copy link
Member

I think it would make more sense to change the u8 use with uint8_t

@sharkwouter sharkwouter merged commit d7d5d75 into pspdev:master Oct 31, 2024
1 check passed
@joel16
Copy link
Contributor

joel16 commented Oct 31, 2024

I think it would make more sense to change the u8 use with uint8_t

This change makes it inconsistent with the other headers. Most headers use the types from psptypes.h.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diamant3 diamant3 diamant3 approved these changes

@sharkwouter sharkwouter sharkwouter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wally4000 @sharkwouter @joel16 @diamant3