Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add success level #7

Merged
merged 2 commits into from
Dec 12, 2023
Merged

add success level #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3579e63
add success level
guilhermebodin Dec 8, 2023
5067a46
Merge branch 'master' into gb/add_success_level
guilhermebodin Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/constants.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
const FatalErrorLevel = Logging.LogLevel(3000)
const FATAL_ERROR_LEVEL = Logging.LogLevel(3000)
const SUCCESS_LEVEL = Logging.LogLevel(1)

function set_language(language::AbstractString)
POLYGLOT_LANGUAGE[1] = language
Expand Down
20 changes: 15 additions & 5 deletions src/logger.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,15 @@ function choose_terminal_io(level::LogLevel)
end

function get_level_string(level::LogLevel)
if Logging.Info <= level <= Logging.Error || level == Logging.Debug
return string(level)
if level == SUCCESS_LEVEL
return "Success"
elseif level == FATAL_ERROR_LEVEL
return "Fatal Error"
elseif Logging.Debug < level < Logging.Info
return "Debug Level"
elseif level == FatalErrorLevel
return "Fatal Error"
end
else
string(level)
end
end

function get_tag_brackets(level::LogLevel, brackets_dict::Dict)
Expand Down Expand Up @@ -97,6 +99,7 @@ end
"Debug Level" => ["[", "]"],
"Debug" => ["[", "]"],
"Info" => ["[", "]"],
"Success" => ["[", "]"],
"Warn" => ["[", "]"],
"Error" => ["[", "]"],
"Fatal Error" => ["[", "]"],
Expand All @@ -106,6 +109,7 @@ end
"Debug Level" => "Debug Level",
"Debug" => "Debug",
"Info" => "Info",
"Success" => "Success",
"Warn" => "Warn",
"Error" => "Error"
)
Expand All @@ -114,6 +118,7 @@ end
"Debug Level" => :cyan,
"Debug" => :cyan,
"Info" => :cyan,
"Success" => :green,
"Warn" => :yellow,
"Error" => :red,
"Fatal Error" => :red
Expand All @@ -123,6 +128,7 @@ end
"Debug Level" => false,
"Debug" => false,
"Info" => false,
"Success" => false,
"Warn" => false,
"Error" => false,
"Fatal Error" => true
Expand All @@ -137,6 +143,7 @@ function create_polyglot_logger(
"Debug Level" => ["[", "]"],
"Debug" => ["[", "]"],
"Info" => ["[", "]"],
"Success" => ["[", "]"],
"Warn" => ["[", "]"],
"Error" => ["[", "]"],
"Fatal Error" => ["[", "]"],
Expand All @@ -145,6 +152,7 @@ function create_polyglot_logger(
"Debug Level" => "Debug Level",
"Debug" => "Debug",
"Info" => "Info",
"Success" => "Success",
"Warn" => "Warn",
"Error" => "Error",
"Fatal Error" => "Fatal Error",
Expand All @@ -153,6 +161,7 @@ function create_polyglot_logger(
"Debug Level" => :cyan,
"Debug" => :cyan,
"Info" => :cyan,
"Success" => :green,
"Warn" => :yellow,
"Error" => :red,
"Fatal Error" => :red,
Expand All @@ -161,6 +170,7 @@ function create_polyglot_logger(
"Debug Level" => false,
"Debug" => false,
"Info" => false,
"Success" => false,
"Warn" => false,
"Error" => false,
"Fatal Error" => true,
Expand Down
9 changes: 7 additions & 2 deletions src/logs.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ function info(msg::AbstractString)
return nothing
end

function success(msg::AbstractString)
@logmsg Logging.LogLevel(SUCCESS_LEVEL) msg
return nothing
end

function warn(msg::AbstractString)
@warn msg
return nothing
Expand All @@ -24,10 +29,10 @@ function fatal_error(
msg::AbstractString;
exception::Exception = ErrorException("Fatal error"),
)
@logmsg FATAL_ERROR_LEVEL msg

logger = Logging.global_logger()
close_polyglot_logger(logger)

@logmsg FatalErrorLevel msg
throw(exception)
return nothing
end
Expand Down
1 change: 1 addition & 0 deletions test/test_log_levels.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ function test_log_levels_on_file()
)
LoggingPolyglot.debug("debug")
LoggingPolyglot.info("info")
LoggingPolyglot.success("success")
LoggingPolyglot.warn("warn")
LoggingPolyglot.non_fatal_error("non_fatal_error")
logs_on_file = readlines(log_path)
Expand Down
Loading