Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set 'ssl_verify' config for jira plugin #169

Merged
merged 1 commit into from
Dec 19, 2018

Conversation

qiankehan
Copy link
Contributor

Add optional 'ssl_verify' to jira plugin for enabling or disabling ssl
verification. This configuration is true by default.

Signed-off-by: Han Han [email protected]

@coveralls
Copy link

coveralls commented Dec 10, 2018

Coverage Status

Coverage decreased (-0.04%) to 81.883% when pulling a8b33b8 on qiankehan:jira_ssl into 3c34c94 on psss:master.

Add optional 'ssl_verify' to jira plugin for enabling or disabling ssl
verification. This configuration is true by default.

Signed-off-by: Han Han <[email protected]>
@qiankehan
Copy link
Contributor Author

Add test function for ssl_verify in jira plugin.

@psss psss self-assigned this Dec 19, 2018
psss added a commit that referenced this pull request Dec 19, 2018
@psss
Copy link
Owner

psss commented Dec 19, 2018

Thanks for the enhancement. I did a bit of cleanup in 0ecfaa1 and merged it.
Note that it's always better to have ssl verification enabled. See also:
https://did.readthedocs.io/en/latest/questions/#certificates

@psss psss merged commit a8b33b8 into psss:master Dec 19, 2018
@qiankehan qiankehan deleted the jira_ssl branch December 20, 2018 09:41
psss added a commit to mweetman-redhat/did that referenced this pull request Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants