Fail on error, support array operations, CompositeTypes, quoted identifiers and single-member enums #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ifiers and single-member enums This makes the library capable of handling the TypeScript types as generated by recent versions of the Supabase CLI as well as makes it able to cover some more exotic scenarios like the aforementioned single-member enums and quoted identifiers.
TomasHubelbauer
commented
Jun 26, 2024
There was a problem hiding this comment.
I added this to support the bun run temp script without having to remember to not commit the sandbox stuff.
| sourceText: parsedTypes, | ||
| ...opts, | ||
| }); | ||
|
|
||
| if (errors.length > 0) { | ||
| throw new Error(errors.join('\n')); |
There was a problem hiding this comment.
Let me know if you find this behavior undesirable, but I think it is reasonable to fail fast and save the users confusion down the line in case they find some types are missing.
|
Fixes #29. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the library capable of handling the TypeScript types as generated by recent versions of the Supabase CLI as well as makes it able to cover some more exotic scenarios like the aforementioned single-member enums and quoted identifiers.