Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #625

Merged
merged 4 commits into from
Jul 1, 2021
Merged

Update dependencies #625

merged 4 commits into from
Jul 1, 2021

Conversation

eduardosm
Copy link
Collaborator

No description provided.

@psychon
Copy link
Owner

psychon commented Jul 1, 2021

I guess "nix broke" is a good reason to bump the MSRV. :-(

Edit: The relevant commit seems to be nix-rust/nix@5ac876e#diff-053ba1e724c4502bd141984f3ba3b1a5f4a4eddde4566eb196d39107b068fc76 and it really goes from Rust 1.40.0 to 1.41.0 in a couple of places.

@eduardosm
Copy link
Collaborator Author

I guess "nix broke" is a good reason to bump the MSRV. :-(

As you prefer, I was about to rollback to 0.20 and list it in #538.

@psychon
Copy link
Owner

psychon commented Jul 1, 2021

Feel free to bump to 1.41. Seems like that also means "newer smol" (thanks for the link; I totally forgot about #538)

This reverts commit d9f31f255a8402360897703a7ab9b50745e161b2.

cairo-rs 0.14 needs rust 1.51, so we stay on 0.9 for now
@eduardosm
Copy link
Collaborator Author

eduardosm commented Jul 1, 2021

It looks like it is not going to be that easy, some dependencies of the newer smol (async-lock and socket2) have further bumped their MSRV and do not build with 1.41 anymore. It seems at least 1.46 would be needed.

Allows to use nix 0.21
@psychon
Copy link
Owner

psychon commented Jul 1, 2021

I updated the branch protection rule: Removed build (1.40.0) and added build (1.41.1), but apparently that does not apply to this PR...?

However, that reminds me: You also need to update .mergify.yml for the new name of the check.

@eduardosm
Copy link
Collaborator Author

However, that reminds me: You also need to update .mergify.yml for the new name of the check.

I did update it

@psychon
Copy link
Owner

psychon commented Jul 1, 2021

Oh, sorry.

@psychon psychon merged commit b7cad45 into master Jul 1, 2021
@psychon psychon deleted the update-deps branch July 1, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants