correct handling of __eq__ comparison of ranges with non-ranges #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, or maybe it should just "return False", which actually works where I hit this better than the TypeError above. What are your thoughts? |
… with SQLAlchemy's internal state tracking
|
I think returning false is a better option, yes: Also, checking self.class is probably too strict (or just wrong) w.r.t. subclassing: think e.g. (just making up) if there is a IntRange subclassed in a PositiveIntRange I think your implementation would give different values checking |
|
That looks cool, thank you. Will merge soon-ish. |
dvarrazzo
added a commit
that referenced
this pull request
Jun 18, 2013
Not an original psycopg2 bug but present in pure python implementation, e.g. ctypes issue #25 and cffi issue #5. mvantellingen/psycopg2-ctypes#25 chtd/psycopg2cffi#5
dvarrazzo
added a commit
that referenced
this pull request
Jun 18, 2013
Not an original psycopg2 bug but present in pure python implementation, e.g. ctypes issue #25 and cffi issue #5. mvantellingen/psycopg2-ctypes#25 chtd/psycopg2cffi#5
dvarrazzo
added a commit
that referenced
this pull request
May 5, 2014
Not an original psycopg2 bug but present in pure python implementation, e.g. ctypes issue #25 and cffi issue #5. mvantellingen/psycopg2-ctypes#25 chtd/psycopg2cffi#5
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally thought a more useful error message was all that's needed, but it turns out that raising any exception here causes problems with SQLAlchemy's internal state tracking.