Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] [metered register] Improvement component #163

Merged
merged 9 commits into from
Oct 16, 2023
Merged

[Feat] [metered register] Improvement component #163

merged 9 commits into from
Oct 16, 2023

Conversation

billsur
Copy link
Contributor

@billsur billsur commented Oct 13, 2023 •
edited
Loading

Pull Request

Description

Cheklist Sebelum di Merge:

  • Apakah tidak ada error ketika di cek menggunakan linter
  • Apakah telah dibuat Unit Test
  • Apakah sudah sesuai code Guideline yang disepakati oleh Team (Code Splitting, Response Handling dll)
  • Apakah sudah di self-review
  • Apakah sudah diberi komentar di bagian yang sulit dimengerti
  • Apakah tidak ada error di local
  • Apakah kemungkinan membutuhkan perubahan di fungsi/fitur lain?

Keterangan Azure Devops

@billsur billsur self-assigned this Oct 13, 2023
@billsur billsur added the enhancement New feature or request label Oct 13, 2023
@andysabtian
Copy link
Contributor

please recheck unit test

@andysabtian andysabtian merged commit 0cc6535 into master Oct 16, 2023
1 check passed
@billsur billsur deleted the feat/metered-register/adjustment-component branch October 16, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andysabtian andysabtian andysabtian approved these changes

@prasetiyo28 prasetiyo28 Awaiting requested review from prasetiyo28

Assignees

@billsur billsur

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@billsur @andysabtian