Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not show strings with password in notification text #4761

Merged
merged 1 commit into from
Aug 23, 2023
Merged

do not show strings with password in notification text #4761

merged 1 commit into from
Aug 23, 2023

Conversation

djohts
Copy link

@djohts djohts commented Apr 21, 2023

No description provided.

@Boy132
Copy link
Contributor

Boy132 commented Apr 21, 2023

The password is shown on the screen anyways, so why hide it in the little notification?

@djohts
Copy link
Author

djohts commented Apr 24, 2023

The password is shown on the screen anyways, so why hide it in the little notification?

at least because the notification doesn't look really good on phones when copying JDBC connection string

@matthewpi matthewpi merged commit 97049f4 into pterodactyl:1.0-develop Aug 23, 2023
7 checks passed
@djohts djohts deleted the patch-1 branch August 23, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewpi matthewpi matthewpi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Backlog
Status: 🎉 Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djohts @Boy132 @matthewpi