-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dependency versions #106
Conversation
Hi, although
I have encountered issues because of this when cosmwasm-std upgraded from 1.0.0 directly to 1.1.0 not long ago. I think to prevent this, packages should be versioned started from x.x.1 instead of x.x.0. But it seems many packages are doing that and I have not used rust long enough to understand. Anyway, another workaround is to specific the long dependency format such as: Please consider adding this to prevent unexpected errors. |
@@ -36,7 +36,7 @@ fi | |||
docker run --rm -v "$(pwd)":/code \ | |||
--mount type=volume,source="$(basename "$(pwd)")_cache",target=/code/target \ | |||
--mount type=volume,source=registry_cache,target=/usr/local/cargo/registry \ | |||
${image}:0.12.9 | |||
${image}:0.12.11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update rust-optimizer version
@@ -56,6 +56,8 @@ for d in contracts/*; do | |||
cd ../.. | |||
fi | |||
done | |||
|
|||
rm -rf contracts/**/schema/raw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The raw schema folders don't need to be committed
Should we bump the main version to v1.0.1 for parity with cw-plus? I don't think we need to since this is a different repo now. |
I expect we will still see major API changes in the repo. I think we should only tag v1 here once we are confident there won't be any major API change here. |
Only specify the first one or two positions in semvar. E.g.cosmwasm-std 1.2
instead ofcosmwasm-std 1.2.0
. @apollo-sturdy recently told me that these actually mean exactly the same - if you runcargo update
, cargo updates the package to the latest under1.*.*
regardless whether you specify the version as1
or1.2
or1.2.0