Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Multiindex for TokenIndexes works by accident and not by design
The key on a token index should be a String and not an Addr
The conversion of Addr to String is why existing setup does not fail any unit tests
An example usage below:
If we have this data
The type structure being
To uniquely identify each entry, I need to differentiate by the key, which in this case is a String
The purpose of the index, is to get token ids by providing an owner address. So,
input:
<addr1>
output:
["1", "2"]
so the index is by owner and then I get back the keys associated with it ["1", "2"]
Note that an owner (addr) can have multiple token ids (string)
So index by owner, is similar to tokens "group by" owner