feat: add cw721-non-transferable contract #85
Conversation
| ExecuteMsg::Mint(msg) => { | ||
| Cw721NonTransferableContract::default().mint(deps, env, info, msg) | ||
| } | ||
| _ => Err(ContractError::Unauthorized {}), |
There was a problem hiding this comment.
Personally I prefer more descriptive error messages than just "unauthorized", e.g. something like "only admin can transfer this token". However I understand this requires modifying the error type in cw721-base which is out-of-scope for this PR.
There was a problem hiding this comment.
+1 for more descriptive errors, but as you said, adding a new error type to the cw721-base is out-of-scope, will take it into account for a future PR
|
Thanks for the great feedback @larry0x! I've addressed your comments. Lmk if it looks good to you. On another topic, I've mistakenly opened the PR from my fork's main branch instead of the feature one. I can open a new PR and close this one to not have those annoying |
I would just squash-merge |
Co-authored-by: Larry Engineer <[email protected]>
This PR includes a contract for implementing non-transferable (aka soulbound) NFTs.