Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore to revert #346

Merged
merged 13 commits into from
Jul 15, 2019
Merged

Restore to revert #346

merged 13 commits into from
Jul 15, 2019

Conversation

sashadev-sky
Copy link
Member

References #87 - add an img.revert() which reverts it to orig dimensions and rotation:

  • I update the "Restore" action to "Revert", and updated the private method _restore to _revert (and updated README)

  • Will have to be updated in MK (sorry will inline the svg in new PR asap)

  • Pulled out from PR Matrix math and other code cleanups #339 as requested

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updates
  • @mention the original creator of the issue in a comment below for help or for a review

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@sashadev-sky
Copy link
Member Author

@jywarren this is ready for merge if you think so too!

@jywarren jywarren merged commit 3b27c1e into publiclab:main Jul 15, 2019
@jywarren
Copy link
Member

Nice!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants