Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config.yml #159

Merged
merged 4 commits into from
Oct 29, 2018
Merged

Update config.yml #159

merged 4 commits into from
Oct 29, 2018

Conversation

faithngetich
Copy link
Contributor

@faithngetich faithngetich commented Oct 12, 2018

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

Fixes publiclab/plots2#3681

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@welcome
Copy link

welcome bot commented Oct 12, 2018

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests. There may be some errors, but don't worry! We're here to help! 👍🎉😄

@DivyeshPuri
Copy link
Contributor

@faithngetich Can you please reference the issue number corresponding to this PR so that we can have a look at what issue you are trying to solve.

@faithngetich
Copy link
Contributor Author

@DivyeshPuri Issue link

Copy link
Contributor

@DivyeshPuri DivyeshPuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Great Work 🎉

Copy link

@Rishabh570 Rishabh570 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Congrats on merging your first pull request! 🙌🎉⚡️
firstPRMergeComment: |
Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://code.publiclab.org in the next few days.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Here we may want to keep plain publiclab.org as that's where the code will be published. Would you mind making this change? Thanks!!!!

@faithngetich
Copy link
Contributor Author

@jywarren I've made the changes, let me know if my change is as expected.

@jywarren
Copy link
Member

Ah, i'm sorry - could we actually add back in the https:// because i don't believe it will appear as a link otherwise! Thank you

@faithngetich
Copy link
Contributor Author

No worries @jywarren , I have added.

Copy link
Member

@grvsachdeva grvsachdeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@ghost ghost assigned jywarren Oct 26, 2018
@jywarren jywarren merged commit 689a346 into publiclab:master Oct 29, 2018
@welcome
Copy link

welcome bot commented Oct 29, 2018

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://publiclab.org in the next few days.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[multiple-use] Copy welcomebot and first-timers-only templates into other projects
5 participants