-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update config.yml #159
Update config.yml #159
Conversation
Thanks for opening this pull request! |
@faithngetich Can you please reference the issue number corresponding to this PR so that we can have a look at what issue you are trying to solve. |
@DivyeshPuri Issue link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Great Work 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
.github/config.yml
Outdated
Congrats on merging your first pull request! 🙌🎉⚡️ | ||
firstPRMergeComment: | | ||
Congrats on merging your first pull request! 🙌🎉⚡️ | ||
Your code will likely be published to https://code.publiclab.org in the next few days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Here we may want to keep plain publiclab.org as that's where the code will be published. Would you mind making this change? Thanks!!!!
@jywarren I've made the changes, let me know if my change is as expected. |
Ah, i'm sorry - could we actually add back in the |
No worries @jywarren , I have added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Congrats on merging your first pull request! 🙌🎉⚡️ |
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
Fixes publiclab/plots2#3681
rake test
fixes #0000
-style reference to original issue #@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.
Thanks!