Added catch block to failed API calls

[somenath1435]

fixes #284
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• PR body includes fixes #0000-style reference to original issue #
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

[welcome]

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

[somenath1435]

@jywarren @Rishabh570 please review

[Rishabh570]

Hi @somenath1435, yes this file might be the origin of the bug but we need to propagate the error to the main file, so you need to throw err here instead of logging it. Also, for that, the whole structure of this function will change...as the functions are themselves async you can remove the return new Promise... wrapper and in the "if & else" you can do then & catch instead. I hope I helped.

Thanks!!!

[somenath1435]

@Rishabh570 I've logged the error as well as thrown the error in the current PR

[somenath1435]

@Rishabh570 please suggest

[somenath1435]

@Rishabh570 any suggestions??

[Rishabh570]

I guess this won't be the right way to throw an error, resolve() will receive the error object. We need to have the functions have the catch callback instead of return Promise...