-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Support Label link on Navbar #541
Conversation
Thanks for opening this pull request! |
Hi @TildaDares. Could you please approve the running workflows for my PR? Thank you. |
Hi @TildaDares. I have made another commit to fix the previously failing tests. Could you please approve the workflow once more? Thank you. |
Hi @PeculiarE, can you remove the |
This reverts commit 0826431.
Hiya @TildaDares....when I made the first commit, the tests on the PR were failing and when I checked the log, the issue was related to failure to install dependencies. I then thought it was because I didn't install the dependencies on my local and just only edited the typo on the So I went back to my branch on my PC, did npm install, ran the build just to be sure, and then ran tests. The tests passed but the I have reverted the changes and removed both files from the PR as requested. I'm just puzzled why the tests didn't pass since it was only the |
Congrats on merging your first pull request! 🙌🎉⚡️ |
Congratulations 🎉🎊 |
Thank you, Tilda! 😃 🥳 |
Fixed Support Label link on Navbar
Updated the file index.html for the proposed changes
Fixes #540
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
fixes #0000
-style reference to original issue #@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.
Thanks!