Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Support Label link on Navbar #541

Merged
merged 3 commits into from
Apr 1, 2022

Conversation

PeculiarE
Copy link
Contributor

@PeculiarE PeculiarE commented Mar 28, 2022

Fixed Support Label link on Navbar
Updated the file index.html for the proposed changes

Fixes #540

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@welcome
Copy link

welcome bot commented Mar 28, 2022

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@PeculiarE
Copy link
Contributor Author

PeculiarE commented Mar 28, 2022

Hi @TildaDares. Could you please approve the running workflows for my PR? Thank you.

@PeculiarE
Copy link
Contributor Author

Hi @TildaDares. I have made another commit to fix the previously failing tests. Could you please approve the workflow once more? Thank you.

@TildaDares
Copy link
Member

Hi @PeculiarE, can you remove the package-lock.json and dist/community-toolbox.js files from this PR? Thanks!

This reverts commit 0826431.
@PeculiarE
Copy link
Contributor Author

Hiya @TildaDares....when I made the first commit, the tests on the PR were failing and when I checked the log, the issue was related to failure to install dependencies. I then thought it was because I didn't install the dependencies on my local and just only edited the typo on theindex.htmlfile.

So I went back to my branch on my PC, did npm install, ran the build just to be sure, and then ran tests. The tests passed but the package-lock.json and dist/community-toolbox.js files had changes. I thought that committing these changes would fix the failing tests on Github. Turns out I was wrong as the tests are still failing here on Github even though they're passing on my local machine. Do you have any idea why that is?

I have reverted the changes and removed both files from the PR as requested. I'm just puzzled why the tests didn't pass since it was only the index.html file I edited.

@TildaDares TildaDares merged commit 8b83092 into publiclab:main Apr 1, 2022
@welcome
Copy link

welcome bot commented Apr 1, 2022

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://code.publiclab.org in the next few days.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

@TildaDares
Copy link
Member

Congratulations 🎉🎊

@PeculiarE
Copy link
Contributor Author

Thank you, Tilda! 😃 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Support Label link in Navbar
2 participants