Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add select dropdown for some module UIs in demo #142

Closed
jywarren opened this issue Oct 17, 2017 · 4 comments
Closed

Add select dropdown for some module UIs in demo #142

jywarren opened this issue Oct 17, 2017 · 4 comments

Comments

@jywarren
Copy link
Member

This line of code inserts an <input> for each module option, so that users can change that option in the demo interface:

https://github.com/publiclab/image-sequencer/blob/master/examples/demo.js#L68

Try that out here: https://publiclab.github.io/image-sequencer/examples/

Some modules have options of type select instead of type integer or string, like this one: https://github.com/publiclab/image-sequencer/blob/master/src/modules/SegmentedColormap/info.json#L5

Compare that to this module, which specifies an integer: https://github.com/publiclab/image-sequencer/blob/master/src/modules/Crop/info.json#L7

When a select is specified, we should insert a <select> element and the various options as a dropdown, rather than a text input.

Would love help with this!

@jywarren
Copy link
Member Author

It seems you've just enabled the issue triaging. I'm just scraping all issues from your repository and will give you some more information about this in a few minutes or so.

Because of the rate limit we can't scrape all information (including all comments and authors) right now - our system is already set up to scrape this in the next days over which the predictions will become more precise every day.

Sit tight!

@jywarren
Copy link
Member Author

The contributors most likely able to help are:

@jywarren
@ccpandhare

@ccpandhare
Copy link
Collaborator

I shall take this up today

@jywarren
Copy link
Member Author

jywarren commented Oct 18, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants