Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Bug Stomp February" - A Bug Fixing Marathon #1624

Open
harshkhandeparkar opened this issue Feb 12, 2020 · 14 comments
Open

"Bug Stomp February" - A Bug Fixing Marathon #1624

harshkhandeparkar opened this issue Feb 12, 2020 · 14 comments

Comments

@harshkhandeparkar
Copy link
Member

harshkhandeparkar commented Feb 12, 2020

Why

It seems that ImageSequencer has a lot of bugs and optimization issues. For example, it does not work on Firefox #1211.

We trying to add awesome features like Face Detection and Motion Blur. Just look at the contributions below.
Screenshot from 2020-02-12 22-55-45
This is superb! This is the sign of a bustling community.

But there is one problem with this. The bugs. There are 72 open PRs out of which, a major portion is facing Travis failure. And it is during the debugging of these, that we find new bugs which are a result of old, unmaintained and unprotected (untested) code. Have a look at #1623 for example. Such issues should have been fixed a long while ago.

If we continue adding new features without fixing old bugs, we are going to face a huge roadblock where the new features will be hindered by old bugs and the features would introduce more bugs. We are just going deeper and deeper into a black hole. We need to act fast. We have to fix these bugs before we cross the event horizon, the point of no return! I am overdramatizing this but this is pretty serious.

The Campaign

This February, let's take a break from our usual issues, new feature implementation and completion of old PRs. Let's just step away from our existing PRs and start fixing bugs!
Let us all claim at least one issue marked as a bug and get it fixed by the end of February. Even if you don't know how to proceed, just claim it. Do some research. I am sure you will find a solution.
If your PR gets merged early, you could even claim a new one and stomp it too!

You could help us by reporting bugs too!

What You Will Learn

Debugging is something you learn only by experience. In the process of fixing a bug, you can learn a lot. You may learn to use a new feature of some programming language. You may start understanding a difficult concept better. Even quirky behaviors of obscure features will start making sense.

Let us all fix at least one bug by the end of February and maintain a list of the bugs we have "stomped". At the end of this campaign, the first week of March, we are going to have a week-long testing campaign wherein everyone adds a test to ImageSequencer to secure it from future bugs. The bugs fixed during this campaign will be linked to a test in the upcoming March campaign.

Open PRs

  1. Fix error in replaceImage function #1625 by @blurry-x-face
  2. Fixes error on | character in CLI #1634 by @blurry-x-face

List of Stomped Bugs

  1. Edge detect is not working correctly #1576 in Edge Detect Fixed! #1629
  2. Edge Detect Possibly Glitching on Horizontal Edges #1632 in Edge Detect Horizontal Edges Got Fixed #1696

NOTE: We will try not to focus on/merge PRs other than bug fixes this month.


Thank You!

cc @jywarren @publiclab/is-reviewers

@harshkhandeparkar
Copy link
Member Author

Let us know the bug that you have claimed in the comments of this thread, below ⬇️.

@rishabhshuklax
Copy link
Member

Would really love to be part of this Campaign 😄

@ataata107
Copy link

I am in for this

@harshkhandeparkar
Copy link
Member Author

harshkhandeparkar commented Feb 12, 2020 via email

@niravasher
Copy link

Always in for this

@rishabhshuklax
Copy link
Member

I've claimed #1098 😃

@harshkhandeparkar
Copy link
Member Author

Hey guys! Please try to claim an issue by the end of this week so that you have at least a week to work on it and we have a week to review it. Also mention about it here.

Thank you!

@ataata107
Copy link

I will complete #1468 and #1470 as soon as #1571 is merged. I have already opened prs for both the issues but will complete them and try to get them merged.

@harshkhandeparkar harshkhandeparkar pinned this issue Feb 15, 2020
@harshkhandeparkar
Copy link
Member Author

I'll be working on #1576 for Bug Stomp February!

@harshkhandeparkar
Copy link
Member Author

PR Opened! #1629

@harshkhandeparkar
Copy link
Member Author

Hi everyone! If you have claimed or are planning to fix a bug, please mark the issue (and PR) with the label "Bug Stomp February" so that we can keep track of everything and possibly archive it.

@rishabhshuklax
Copy link
Member

Opened PR #1634 for issues #1033 and #1040

@rishabhshuklax
Copy link
Member

Opened PR #1625 for issues #1098 #147 #1030

@jywarren
Copy link
Member

jywarren commented Mar 3, 2020

Hi all! Getting plugged in again here! I don't have as many hours per week as before but will focus on reviewing and merging these first! Then, will fix a bug myself!!!! Thanks everyone!!! 🎉🎉🎉🎉

@jywarren jywarren unpinned this issue Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants