Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set of smaller issues for Run() and AddStep/InsertStep #261

Closed
2 tasks
jywarren opened this issue May 23, 2018 · 1 comment
Closed
2 tasks

Set of smaller issues for Run() and AddStep/InsertStep #261

jywarren opened this issue May 23, 2018 · 1 comment
Assignees
@tech4GT
Labels
enhancement new-feature
Milestone
Core work

Comments

@jywarren
Copy link
Member

  • rename Run() parameters to be a bit easier to follow (instead of "ref", "json_q", something descriptive)
  • reduce redundancy of AddStep and InsertStep -- AddStep should be a more specific use of InsertStep and largely use the same code but just have a position (at the end of the sequence) hard-coded
@jywarren jywarren mentioned this issue May 23, 2018
Merged
@jywarren
Copy link
Member Author

GitMate.io thinks possibly related issues are #227 (PLANNING ISSUE), #48 (A Semantic Issue), #25 (Issues With ImageManipulation.js), #118 (Assorted improvements to be broken into separate issues), and #165 (Various module ideas to be broken out into separate issues).

@jywarren jywarren mentioned this issue May 28, 2018
Merged
@jywarren jywarren added this to the Core work milestone Jun 1, 2018
@jywarren jywarren changed the title Set of smaller maintenance issues Set of smaller maintenance issues for Run() and AddStep/InsertStep Jun 3, 2018
@jywarren jywarren changed the title Set of smaller maintenance issues for Run() and AddStep/InsertStep Set of smaller issues for Run() and AddStep/InsertStep Jun 3, 2018
@gitmate gitmate bot mentioned this issue Jun 8, 2018
Closed
tech4GT added a commit to tech4GT/image-sequencer that referenced this issue Jun 21, 2018
@tech4GT
reduce redundance of add and insert fixes publiclab#261
93abe7d 
Signed-off-by: tech4GT <[email protected]>
@ghost ghost assigned tech4GT Jun 21, 2018
@ghost ghost added the in-progress label Jun 21, 2018
@tech4GT tech4GT mentioned this issue Jun 21, 2018
Merged
@ghost ghost removed the in-progress label Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tech4GT tech4GT

Labels
enhancement new-feature
Projects
None yet
Milestone
Core work
Development

No branches or pull requests
2 participants
@jywarren @tech4GT