Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a success prompt for saved sequence #342

Closed
tech4GT opened this issue Sep 28, 2018 · 2 comments
Closed

Add a success prompt for saved sequence #342

tech4GT opened this issue Sep 28, 2018 · 2 comments
Labels
coding Issue related to code fto-candidate gci-candidate Issue being considered for gci small

Comments

@tech4GT
Copy link
Member

tech4GT commented Sep 28, 2018

We are preparing to participate in Google Code-in, and have reserved this issue for participants in GCI - but we'd love to have your help with another one! Please check out https://code.publiclab.org to see more.

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

The Problem:

We want to show a success message to the user if the sequence was successfully saved

How to Solve?

You can print the message to the user's screen like this

console.log("Your sequence was saved successfully!!");

This line can be added below this one.

sequencer.saveSequence(params[0], params[1]);

Bonus: It would be really nice if the prompt is colored green. You can take hint from the following line

console.warn(

Also you can find the codes for all colors here https://stackoverflow.com/questions/9781218/how-to-change-node-jss-console-font-color

Instance Count 1

@gitmate
Copy link

gitmate bot commented Sep 28, 2018

GitMate.io thinks the contributors most likely able to help are @jywarren, and @GitMate[bot].

Possibly related issues are #277 (add sequencer.importString()), #27 (add fisheyegl module), #157 (Add a Contrast module), and #338 (Display an installation message to user in the CLI).

1 similar comment
@gitmate
Copy link

gitmate bot commented Sep 28, 2018

GitMate.io thinks the contributors most likely able to help are @jywarren, and @GitMate[bot].

Possibly related issues are #277 (add sequencer.importString()), #27 (add fisheyegl module), #157 (Add a Contrast module), and #338 (Display an installation message to user in the CLI).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coding Issue related to code fto-candidate gci-candidate Issue being considered for gci small
Projects
None yet
Development

No branches or pull requests

1 participant