Module save button is sometimes greyed out when needed

[jywarren]

I'm seeing this on the Convolution module but it may affect all modules.

We could start by finding the line of code which drives this in the UI code!

Thanks!

[gitmate]

GitMate.io thinks possibly related issues are #231 ("Save as module" button on Dynamic module), #302 (Disable/dim the Save button until step inputs have been changed), #373 (Button to top), #303 (Disable/dim the Add step button until a module is selected), and #108 (Math Module).

[gitmate]

GitMate.io thinks possibly related issues are #231 ("Save as module" button on Dynamic module), #302 (Disable/dim the Save button until step inputs have been changed), #373 (Button to top), #303 (Disable/dim the Add step button until a module is selected), and #108 (Math Module).

[Mridul97]

@jywarren I think this is happening because in the code below it is querySelector where as it should be querySelectorAll!

image-sequencer/examples/lib/defaultHtmlStepUi.js

Line 101 in 70654a5

$(step.ui.querySelector(".target")).change(toggleSaveButton);

[jywarren]

oh awesome, good catch! This could be a first-timers-only issue, then. :-)

…

On Thu, Oct 4, 2018 at 1:15 PM Mridul97 ***@***.***> wrote: @jywarren <https://github.com/jywarren> I think this is happening because in the code below it is querySelector where as it should be querySelectorAll! https://github.com/publiclab/image-sequencer/blob/70654a5aace44893e9940ea6b902b875d7e4cddc/examples/lib/defaultHtmlStepUi.js#L101 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#377 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ2-0bA55nAFg6rclmuRuUjLGvqfeks5uhkIFgaJpZM4XIh6G> .

[tech4GT]

@jywarren There is more to this issue as pointed out by @Ankit-Singla on #340
Both of these can be fixed together I think then.
cc @Ankit-Singla

[jywarren]

Hmm, #340 is now live, but I still see this happening. Maybe there is another sneaky bug in there somewhere?

https://publiclab.github.io/image-sequencer/examples/#steps=convolution{constantFactor:0.1111111111111111|kernelValues:1%201%201%201%201%201%201%201%201}

[Ankit-Singla]

I have not yet raised a PR for #340. I intend to figure out the bug here and try to solve both the issues together, as they seem to be a part related to each other.
Shall I go ahead? @jywarren

[jywarren]

yes please! thank you!

…

On Fri, Oct 5, 2018 at 12:27 PM Ankit Singla ***@***.***> wrote: I have not yet raised a PR for #340 <#340>. I intend to figure out the bug here and try to solve both the issues together, as they seem to be a part related to each other. Shall I go ahead? @jywarren <https://github.com/jywarren> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#377 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ_-heO6I0A3JtSrndiqktrrbp-ZJks5uh4g7gaJpZM4XIh6G> .

[jywarren]

I think this has maybe been figured out? I haven't seen it happen recently.

[aashna27]

Is anybody working on it ?

[jywarren]

It may be worth testing out the latest code, as I think there have been some various submitted fixes!

…

On Fri, Jan 4, 2019 at 1:17 PM aashna27 ***@***.***> wrote: Is anybody working on it ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#377 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJyIV7jyLpgpP4kVEd__elchzdhcSks5u_5qLgaJpZM4XIh6G> .

[harshkhandeparkar]

I am working on this. #562 (WIP)

[harshkhandeparkar]

@jywarren please close this one.