Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Add QR Module #632

Closed
harshkhandeparkar opened this issue Jan 8, 2019 · 11 comments
Closed

New Add QR Module #632

harshkhandeparkar opened this issue Jan 8, 2019 · 11 comments
Labels
enhancement has-pull-request Issues which have a PR open module New Module idea new-feature

Comments

@harshkhandeparkar
Copy link
Member

harshkhandeparkar commented Jan 8, 2019

Please describe the problem (or idea)

Add a new module called Add QR which adds a QR code to an image like for e.g at the corner.

example:

add-qr-module

In the above GIMP image, there is QR code at the corner which links to https://github.com/publiclab/image-sequencer

This module can take a string input and output a QR code based on that.
Maybe this can help https://www.npmjs.com/package/qrcode

StartingX, StartingY and size inputs can be added in a followup later for image placement. As a simple module, this could add a QR code only to the bottom right corner.

Uses

This module can be used to add a link to an image for maybe profile pictures or even adverts.

@gitmate gitmate bot added module New Module idea new-feature labels Jan 8, 2019
@gitmate
Copy link

gitmate bot commented Jan 8, 2019

GitMate.io thinks the contributors most likely able to help are @jywarren, and @ccpandhare.

Possibly related issues are #157 (Add a Contrast module), #269 (Prior steps need not re-run when a new module is added or deleted), #71 (Implement QR-Decode Module), #5 (image cropping module), and #205 (add "drag to crop" UI feature to Crop module).

1 similar comment
@gitmate
Copy link

gitmate bot commented Jan 8, 2019

GitMate.io thinks the contributors most likely able to help are @jywarren, and @ccpandhare.

Possibly related issues are #157 (Add a Contrast module), #269 (Prior steps need not re-run when a new module is added or deleted), #71 (Implement QR-Decode Module), #5 (image cropping module), and #205 (add "drag to crop" UI feature to Crop module).

@gitmate gitmate bot added the enhancement label Jan 8, 2019
@lakshyabatman
Copy link
Member

@harshkhandeparkar , you meant placing QR code in image linking to Public Labs github profile, right?

@harshkhandeparkar
Copy link
Member Author

That was just an example l. What i meant was that it can take any text input and place a qr code. For example a link

@lakshyabatman
Copy link
Member

Yeah, it is cool! I'll start working on it.

@harshkhandeparkar
Copy link
Member Author

Awesome!!

@Divy123
Copy link
Member

Divy123 commented Jan 26, 2019

Is this issue still open @harshkhandeparkar ?
I would like to work on it.

@harshkhandeparkar
Copy link
Member Author

@Divy123 if @lakshyabatman has not started working on this yet then sure.

@Divy123
Copy link
Member

Divy123 commented Jan 29, 2019

@harshkhandeparkar I have started working on the module.
Just one thing if you can help me out with image manipulation part.
I have got the qr code image data-uri then how should I attach the same to the original image.
thanks

@harshkhandeparkar
Copy link
Member Author

harshkhandeparkar commented Jan 29, 2019

@Divy123 you can use get-pixels to get an ndarray from a data-uri. Then you can replace pixels in the original image with the pixels in the ndarray. I don't know anything about resizing the image though. An example of getpixels can be found here where I have duplicated the original image.

@Divy123
Copy link
Member

Divy123 commented Jan 29, 2019

Thanks for your help.
I will go through it. 😁

@Divy123 Divy123 mentioned this issue Jan 31, 2019
4 tasks
@harshkhandeparkar harshkhandeparkar added the has-pull-request Issues which have a PR open label Feb 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement has-pull-request Issues which have a PR open module New Module idea new-feature
Projects
None yet
Development

No branches or pull requests

3 participants