Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prior steps need not re-run when a new module is added or deleted #269

Closed
jywarren opened this issue May 28, 2018 · 2 comments
Closed

Prior steps need not re-run when a new module is added or deleted #269

jywarren opened this issue May 28, 2018 · 2 comments

Comments

@jywarren
Copy link
Member

In the demo, I see the entire sequence being re-triggered when a module is added or deleted.

We should only have to run the final new step, if a new one is added, and if one is deleted, only the steps after it. Let's look at the logic and if we need to make run() accept a parameter like sequencer.run(startIndex) we can do that.

@jywarren
Copy link
Member Author

GitMate.io thinks possibly related issues are #27 (add fisheyegl module), #138 (Add a Dithering module), #157 (Add a Contrast module), #158 (Add a Saturation Module), and #113 (Add a Brightness module).

@tech4GT
Copy link
Member

tech4GT commented May 28, 2018

@jywarren Actually I also noticed this while working on the getStepApi, but this would call for some major changes in demo architecture or even in the architecture of the sequencer itself, I would suggest we keep this long term, what say?

tech4GT added a commit to tech4GT/image-sequencer that referenced this issue Jun 1, 2018
Signed-off-by: tech4GT <[email protected]>
@tech4GT tech4GT mentioned this issue Jun 1, 2018
@ghost ghost assigned tech4GT Jun 1, 2018
@ghost ghost added the in-progress label Jun 1, 2018
jywarren pushed a commit that referenced this issue Jun 8, 2018
* fixes #269

Signed-off-by: tech4GT <[email protected]>

* update demo

Signed-off-by: tech4GT <[email protected]>

* refactor and comments

Signed-off-by: tech4GT <[email protected]>

* update readme

Signed-off-by: tech4GT <[email protected]>

* updated and refactored

Signed-off-by: tech4GT <[email protected]>

* update readme

Signed-off-by: tech4GT <[email protected]>

* trying to fix tests

Signed-off-by: tech4GT <[email protected]>

* update documentation

Signed-off-by: tech4GT <[email protected]>

* update to config.mode = test

Signed-off-by: tech4GT <[email protected]>

* finaly everything works

Signed-off-by: tech4GT <[email protected]>

* 1.8.0

* update test

Signed-off-by: tech4GT <[email protected]>

* add test for run

Signed-off-by: tech4GT <[email protected]>
@ghost ghost removed the in-progress label Jun 8, 2018
@gitmate gitmate bot mentioned this issue Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants