Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Image step has no insert step button #644

Closed
harshkhandeparkar opened this issue Jan 10, 2019 · 13 comments
Closed

Load Image step has no insert step button #644

harshkhandeparkar opened this issue Jan 10, 2019 · 13 comments
Labels
bug has-pull-request Issues which have a PR open

Comments

@harshkhandeparkar
Copy link
Member

Please describe the problem (or idea)

What happened just before the problem occurred?

All the steps have an +add button which lets the user insert a step in betwee ln but the initial load image step does not.
There should be a button in that step too which lets the user add a step to the start of the sequence.

screenshot_20190110-181650

screenshot_20190110-181655

Please note: This is a screenshot from the gh-pages branch on sequencer.publiclab.org

@gitmate
Copy link

gitmate bot commented Jan 10, 2019

GitMate.io thinks the contributor most likely able to help you is @bhavayAnand9.

Possibly related issues are #49 (image degredation over repeated steps (invert)), #494 (Add 'Take a photo' as another option for initial load image step), #547 (Add Step button and select fields not inline ), #427 (Download and download as gif button not working in image sequencer), and #466 (Add an "insert step" button on each step UI).

1 similar comment
@gitmate
Copy link

gitmate bot commented Jan 10, 2019

GitMate.io thinks the contributor most likely able to help you is @bhavayAnand9.

Possibly related issues are #49 (image degredation over repeated steps (invert)), #494 (Add 'Take a photo' as another option for initial load image step), #547 (Add Step button and select fields not inline ), #427 (Download and download as gif button not working in image sequencer), and #466 (Add an "insert step" button on each step UI).

@aashna27
Copy link

@jywarren what do you think ??

@jywarren
Copy link
Member

Isn't load image always the first module, so it'd have the Add Step box initially? Maybe that's why it didn't have it. Maybe we need to do it but make sure it doesn't show redundantly when there's only 1 step?

@aashna27
Copy link

Isn't load image always the first module, so it'd have the Add Step box initially? Maybe that's why it didn't have it. Maybe we need to do it but make sure it doesn't show redundantly when there's only 1 step?

I am not really sure if it should have "add" button.

@harshkhandeparkar
Copy link
Member Author

Isn't load image always the first module, so it'd have the Add Step box initially? Maybe that's why it didn't have it. Maybe we need to do it but make sure it doesn't show redundantly when there's only 1 step?

I am not really sure if it should have the "add" button.

I think it should as no step can be added in between step 1 i.e. load-image and step 2

@harshithpabbati
Copy link

harshithpabbati commented Feb 14, 2019

do i need to just add the add button in it?? I guess there is no use on adding it .We just add the chosen image and it gets loaded isn't it?? @harshkhandeparkar what do you say??

@harshkhandeparkar
Copy link
Member Author

@harshithpabbati the add button is to insert a new step between the image and the current first step

@harshithpabbati
Copy link

oh ok. Can i work on this???

@harshkhandeparkar
Copy link
Member Author

harshkhandeparkar commented Feb 14, 2019 via email

@harshithpabbati
Copy link

I am almost done with I had a small problem as the add button is not disabled at the load-image
insert

@harshithpabbati
Copy link

Can anyone help me out

@harshkhandeparkar
Copy link
Member Author

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug has-pull-request Issues which have a PR open
Projects
None yet
Development

No branches or pull requests

4 participants