Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding blend module at unavailable offset always shows loading. #648

Closed
Divy123 opened this issue Jan 10, 2019 · 6 comments
Closed

Adding blend module at unavailable offset always shows loading. #648

Divy123 opened this issue Jan 10, 2019 · 6 comments
Labels

Comments

@Divy123
Copy link
Member

Divy123 commented Jan 10, 2019

Please describe the problem (or idea)

On adding Blend module, if the step at offset is not available it always shows loading

One Possible solution:
I think output produced can be made same as input in case of unavailable offset and a notification can be shown for offset unavailable.

Please show us where to look

https://github.com/publiclab/image-sequencer/blob/main/src/modules/Blend/Module.js

@gitmate gitmate bot added the module New Module idea label Jan 10, 2019
@Divy123
Copy link
Member Author

Divy123 commented Jan 10, 2019

@jywarren @tech4GT I would like to work upon this.

@gitmate
Copy link

gitmate bot commented Jan 10, 2019

GitMate.io thinks possibly related issues are #369 (Add a Grayscale module), #27 (add fisheyegl module), #138 (Add a Dithering module), #368 (Add a Gamma module), and #157 (Add a Contrast module).

1 similar comment
@gitmate
Copy link

gitmate bot commented Jan 10, 2019

GitMate.io thinks possibly related issues are #369 (Add a Grayscale module), #27 (add fisheyegl module), #138 (Add a Dithering module), #368 (Add a Gamma module), and #157 (Add a Contrast module).

@jywarren
Copy link
Member

jywarren commented Jan 10, 2019 via email

@harshkhandeparkar
Copy link
Member

@Divy123 wasn't this fixed when notify was implemented? Can this be closed? If yes then please do so. Thanks.

@Divy123
Copy link
Member Author

Divy123 commented Mar 17, 2019

Ya this is fixed. Thanks!!

@Divy123 Divy123 closed this as completed Mar 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants