Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload User Manual #1171

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Upload User Manual #1171

wants to merge 5 commits into from

Conversation

MargaretAN9
Copy link

Fixes #1162
This is a user manual for Image Sequencer that I have been working on. Any edits or tips would be greatly appreciated. First draft is located at https://publiclab.org/notes/MaggPi/06-10-2019/draft-of-public-lab-image-sequencer-user-manual-comments-welcome.

@MargaretAN9 MargaretAN9 self-assigned this Jul 14, 2019
@codecov
Copy link

codecov bot commented Jul 14, 2019

Codecov Report

Merging #1171 into main will increase coverage by 10.31%.
The diff coverage is 64.31%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1171       +/-   ##
===========================================
+ Coverage   55.11%   65.43%   +10.31%     
===========================================
  Files         117      133       +16     
  Lines        2344     2743      +399     
  Branches      360      439       +79     
===========================================
+ Hits         1292     1795      +503     
+ Misses       1052      948      -104     
Impacted Files Coverage Δ
examples/lib/scopeQuery.js 18.51% <ø> (ø)
src/Modules.js 100.00% <ø> (ø)
src/modules/WebglDistort/Module.js 2.29% <0.00%> (ø)
src/ui/SetInputStep.js 12.90% <0.00%> (-1.39%) ⬇️
src/modules/ColorHalftone/Module.js 3.63% <3.63%> (ø)
examples/lib/defaultHtmlStepUi.js 11.35% <4.08%> (-0.85%) ⬇️
examples/lib/intermediateHtmlStepUi.js 11.11% <5.55%> (+0.94%) ⬆️
examples/lib/insertPreview.js 13.15% <20.00%> (-0.36%) ⬇️
src/util/getImageDimensions.js 20.00% <20.00%> (ø)
src/util/isGif.js 20.00% <20.00%> (ø)
... and 102 more

@jywarren jywarren mentioned this pull request Jul 15, 2019
@jywarren jywarren requested a review from a team July 15, 2019 16:17
Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Epic!!!!

Copy link
Member

@harshkhandeparkar harshkhandeparkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOW! I'll go through all of this again.

Copy link
Member

@Divy123 Divy123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something really awesome!!
All the modules having a display with the sample image is amazing.

Just one or two points, I think can help here:
Adding docs for newly added Noise reduction and Minify Image module.

Insert step functionality can be demonstrated.

Also we can link the upcoming colorimetry project which can be something like upcoming applications.

@jywarren
Copy link
Member

Hi @Divy123 @aashna27 @harshkhandeparkar -- would you mind going through this carefully and leaving feedback, even just 👍 if a section looks good? Thank you!

@jywarren jywarren requested a review from aashna27 July 26, 2019 14:29

Usage:

sequencer.loadImage('PATH')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nice thing you can do is add three of the ` character around sections that are code examples, and even ```js above and ``` below, which makes it syntax highlighted for javascript! See the existing README on image sequencer for examples!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// example code:
do();

@jywarren
Copy link
Member

jywarren commented Aug 3, 2019

Hi @publiclab/is-reviewers @Divy123 @aashna27 @harshkhandeparkar would you mind reading through some sections here and offering input? Thank you!

@aashna27
Copy link

aashna27 commented Aug 3, 2019 via email

Copy link
Member

@harshkhandeparkar harshkhandeparkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! This is awesome. So much detail. I would like to suggest a few things.

  1. Could we make this more compact? Since this is a user manual, we could exclude the intro.

  2. There is a modules.md file for module specific instructions, we could exclude that part and link to it as managing two files will be difficult.

  3. Could link to contributing.md instead of a dedicated section. (Or optionally, add it to the footer)

  4. Could we link to the beta site (https://beta.sequencer.publiclab.org) with a disclaimer?

  5. I think you have added some extra stuff to the modules part, could you please add it directly to the modules.md file?

Thank you!
cc @jywarren @aashna27 @MargaretAN9

@gitpod-io
Copy link

gitpod-io bot commented Jul 7, 2020

@harshkhandeparkar harshkhandeparkar requested a review from a team as a code owner October 17, 2020 16:18
Copy link
Member

@harshkhandeparkar harshkhandeparkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better if we put all of this in /docs and split everything into multiple files. Other than that, it is awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation
5 participants