test import string with no configs

[jywarren]

No description provided.

[tech4GT]

@jywarren we have to have the(), they are essential

[jywarren]

I don't think they are -- if we are URL-encoding the commas within functions, we can then do split(',') to separate steps.

[tech4GT]

@jywarren yes we can, if you want I'll do it this way, just some changes please give me five minutes!!

[tech4GT]

Actually @jywarren what happens is we use ( to separate step name and it parameters

[jywarren]

The problem is that we need commas to separate the parameters, so we can't rely on , to separate just steps. This makes me think we ought to just use pure JSON... but can you think of another solution?

[jywarren]

We could separate parameters with pipes |?

[tech4GT]

@jywarren No problem, I have a work around!!

[tech4GT]

No need of pure json

[tech4GT]

@jywarren Please have a look at the new pr that fixes our problem!!

[jywarren]

OK, i pulled it but I think there's one more thing odd with it -- see how the test returns:

    ✖ should be equivalent
    -----------------------
      operator: deepEqual
      expected: |-
        [ { name: 'channel', options: { channel: 'green' } }, { name: 'blur', options: { blur: '2' } }, { name: 'invert', options: {} }, { name: 'blend', options: { blend
: 'function(r1, g1, b1, a1, r2, g2, b2, a2) { return [ r1, g2, b2, a2 ] }' } } ]
      actual: |-
        [ { name: 'green', options: {} }, { name: 'blur', options: {} }, { name: 'invert', options: {} }, { name: 'blend', options: {} } ]
      at: Test.<anonymous> (/home/warren/sites/image-sequencer/test/modules/import-export.js:27:5)
      stack: |-

[jywarren]

But great work!

[jywarren]

I refactored a bit for readability -- but I'm still seeing an error -- i believe it's still because it can't distinguish between commas used to separate steps, and commas used to separate step settings... I think we ought to switch to pipes, because it's tough otherwise!

[jywarren]

I mean we could switch to semicolons...

[jywarren]

OK, this should work!!!

[jywarren]

Hooray! OK awesome. Read through these changes, but they're pretty minimal!