Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no file chosen place #538

Closed
wants to merge 3 commits into from
Closed

Conversation

adiwahyudi02
Copy link

@adiwahyudi02 adiwahyudi02 commented Dec 9, 2018

Fixes #356

Before

After

Add some styles for wrapper div
Thanks!

@welcome
Copy link

welcome bot commented Dec 9, 2018

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

Copy link
Member

@tech4GT tech4GT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh great work! Thanks @adiwahyudi02
Does this also take care of viewport size, I mean this would work on both smaller and larger devices?

@adiwahyudi02
Copy link
Author

i'm not sure, because i've set min-width statically

@tech4GT
Copy link
Member

tech4GT commented Dec 11, 2018

Oh, It would be great if you can try it in different sized viewports, for that you can use you chrome dev tools, just inspect the page and try different screen sizes there. Thanks and great work! 😄

@harshkhandeparkar
Copy link
Member

harshkhandeparkar commented Dec 11, 2018

Will it not look good if the text is rendered below the button?

@Dhiraj240
Copy link
Member

Will it not look good if the text is rendered below the button?

@tech4GT This way will reduce the box size too. @adiwahyudi02 Follow up with this suggestion.

@tech4GT
Copy link
Member

tech4GT commented Dec 13, 2018

I guess that can work too.

@jywarren
Copy link
Member

jywarren commented Jan 6, 2019

This looks beautiful. Could we move it into examples/demo.css? Thank you!!

@harshkhandeparkar
Copy link
Member

harshkhandeparkar commented Jan 6, 2019

@adiwahyudi02 are you still working on this? If yes then you should probably move the changes to examples/demo.css. Also instead of using px can you use something relative like rem?

@harshkhandeparkar
Copy link
Member

Seems like this has been fixed. This PR is redundant. Can it be closed? @jywarren @gauravano

@grvsachdeva
Copy link
Member

Thanks for status update @harshkhandeparkar. This fix is not required due to change in page design @jywarren @tech4GT. Feel free to open the PR if you think anything can be optimized with this. Thanks @adiwahyudi02 for working on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants