-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opaque meta module + test - colorbar #764
Conversation
Signed-off-by: tech4GT <[email protected]>
@jywarren Actually there is no way of testing the options.inBrowser thing since we run the tests in node and inBrowser is false there anyway, haha. Also I think we should resolve circular dependencies while dynamically loading a module into sequencer, thoughts? |
Long term: |
(re:#762) Re parallelize, EXACTLY!!! Re test, can we just do a looks_like comparison with a visually confirmed output image? I just think any test for colorbar would be good. Let's confirm this can be added as a step, it produces an output, and that output looks like a visually confirmed output image. Re circular, I saw your comment and we can try that after this, yeah. Great! |
Also, what went wrong with this Travis build? Thanks!! |
@jywarren Writing up the test and docs for this now! |
Signed-off-by: tech4GT <[email protected]>
var internalSequencer = ImageSequencer({ inBrowser: false }); | ||
console.log('colorbar setup is', internalSequencer); | ||
// ui: false prevents internal logs | ||
var internalSequencer = ImageSequencer({ inBrowser: false, ui: false }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should document this too!
this is great, thanks @tech4GT !!! |
OK - now see: #765! |
(replaces #762) -- copying in description from there:
Re #315 -- an attempt to refactor the colorbar module to be a fully opaque meta module - that is, a module which:
If this works (and it's not running yet -- I'm stuck for some reason because
draw()
is not executing... help!) then we may be able to create a generator for these, which is to say, a way to automate the creation of opaque meta modules given:@publiclab/is-reviewers take a look here, i got inspired and tried it out, but need a bit of help to debug my work!