Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PR and issue templates according to plots2 #160

Merged
merged 1 commit into from
Apr 9, 2019
Merged

Added PR and issue templates according to plots2 #160

merged 1 commit into from
Apr 9, 2019

Conversation

ananyaarun
Copy link
Member

Fixes #159

-Added PR and issue templates following the directory structure of plots2 repo.
-Updated the msg of the bot for newcomers according to plots2.

@ananyaarun
Copy link
Member Author

@jywarren , @gauravano I added PR and issue templates following the plots2 structure.
Also i noticed that the bot msg for newcomers had been updated in a recent PR in the config.yml and first-timers.yml files.
I changes those accordingly too.

Since we made this change in plots2 I think we can create FTO's like this publiclab/plots2#3681, maintain a checklist and update all the public lab repos to follow this structure of templates and bot messages.
Thoughts on this ?


### Please show us where to look

https://publiclab.org/ ...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
https://publiclab.org/ ...
https://publiclab.org/ ... or https://publiclab.github.io/leaflet-environmental-layers/example

There may be some errors, **but don't worry!** We're here to help! 👍🎉😄
Thanks for opening this pull request! This space is [protected by our Code of Conduct](https://publiclab.org/conduct) - and we're here to help.
`Dangerbot` will test out your code and reply in a bit with some pointers and requests.
Also please refer [here](https://github.com/publiclab/plots2/issues/3840) for installation help 💿
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Also please refer [here](https://github.com/publiclab/plots2/issues/3840) for installation help 💿

Your code will likely be published to https://publiclab.github.io/leaflet-environmental-layers/example/ in the next few days.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Your code will likely be published to https://publiclab.github.io/leaflet-environmental-layers/example/ in the next few days.

@@ -4,7 +4,7 @@ If that's you, we're interested in helping you take the first step and can answe

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, **consider leaving this one for someone new**, and looking through our general [help wanted](https://github.com/publiclab/leaflet-environmental-layers/labels/help-wanted) issues. Thanks!
If you have contributed before, **consider leaving this one for someone new**, and looking through our general [help wanted](https://github.com/publiclab/plots2/labels/help-wanted) issues. Thanks!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you have contributed before, **consider leaving this one for someone new**, and looking through our general [help wanted](https://github.com/publiclab/plots2/labels/help-wanted) issues. Thanks!
If you have contributed before, **consider leaving this one for someone new**, and looking through our general [help wanted](https://github.com/publiclab/leaflet-environmental-layers/labels/help-wanted) issues. Thanks!

Copy link
Member

@grvsachdeva grvsachdeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ananyaarun, nice start. Some changes required. Thanks!

@ananyaarun
Copy link
Member Author

ananyaarun commented Apr 6, 2019

@gauravano , I made the required changes. should have noticed the plots2 instead of LEL in my previous commit !! are there any more changes that can be made ?
Also do u think its a good idea to add these templates to other repos as well ?

Copy link
Member

@grvsachdeva grvsachdeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @ananyaarun!

@grvsachdeva
Copy link
Member

And, yes we can do these changes to other repos too as it will help contributors. Thanks!

@ananyaarun
Copy link
Member Author

@gauravano , we can make a checklist on say plots2 to cover all remaining repos and break them into several FTO's ? Shall i do that ?

@grvsachdeva
Copy link
Member

Sure go ahead. Also, at some repos, there might be issues already open in this regard so do check that before including that repo name in your checklist.

Thanks @ananyaarun!

@jywarren jywarren merged commit cb4b728 into publiclab:master Apr 9, 2019
@jywarren
Copy link
Member

jywarren commented Apr 9, 2019

Thank you!!!!! 🎉 🙌

@ananyaarun
Copy link
Member Author

@gauravano @jywarren is this still relevant ?
If so shall we update all the templates according to the work done by @sashadev-sky ?

@sashadev-sky
Copy link
Member

@ananyaarun Are you referring to the issue templates in LDI I made? I spoke to Jeff last week about those, he said he liked them and would be ok with implementing them in other projects, but it's not a priority. If you are interested in updating for LEL go for it!

@ananyaarun
Copy link
Member Author

ananyaarun commented Jun 25, 2019

Yes @sashadev-sky , The ones in LDI
Sure if it is not priority we can put this on hold.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PR and issue template in the .github folder
4 participants