Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make single lines comment to multi line comment #739

Closed
5 tasks
divyabaid16 opened this issue Jun 24, 2019 · 5 comments · Fixed by #740
Closed
5 tasks

Make single lines comment to multi line comment #739

divyabaid16 opened this issue Jun 24, 2019 · 5 comments · Fixed by #740

Comments

@divyabaid16
Copy link
Contributor

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update

In
https://github.com/publiclab/mapknitter/blob/f42755dfc4db43e66f74efbe547488426525f1a0/app/assets/javascripts/knitter.js#L146-#L152

Make these single line comment as a multi-line comment.
Remove \\ from all the 5 lines and add /* at the starting of the first line and */ at the ending of the last (5th line).
/* --------- */

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

@Kunaldargan
Copy link
Contributor

Hi, I'm interested in contributing here.

@divyabaid16
Copy link
Contributor Author

Go ahead @Kunaldargan
Thanks!

@Kunaldargan
Copy link
Contributor

Please let me know if tests are required and how to perform ?

@chaurasia-namrata
Copy link

Hi, I am new to GitHub and want to contribute and learn.

chaurasia-namrata added a commit to chaurasia-namrata/mapknitter that referenced this issue Jun 24, 2019
@chaurasia-namrata
Copy link

I had made the necessary changes. please review them. thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants