Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable/disable editing functionality needed for collaborative image placement #893

Open
ViditChitkara opened this issue Jul 30, 2019 · 10 comments · May be fixed by #937
Open

Enable/disable editing functionality needed for collaborative image placement #893

ViditChitkara opened this issue Jul 30, 2019 · 10 comments · May be fixed by #937

Comments

@ViditChitkara
Copy link
Member

A follow up of #805 , we'll require an enable/disable button which will have the capability to enable or disable synchronous editing with multiple users on a map. This button should only be shown to the author somewhere on the sidebar:-
Screenshot 2019-07-30 at 11 52 45 PM
We may store a field in the map model like "is_enabled" or something which could be used as a check as to whether changes be accepted from a foreign user or not.

@ViditChitkara
Copy link
Member Author

@jywarren @sashadev-sky what do you think?

@ViditChitkara
Copy link
Member Author

related issue: #804

@sashadev-sky
Copy link
Member

Yeah I've been visualizing like a translucent kind of lock icon on the map in a corner let me try to photoshop a pic real quick

@sashadev-sky
Copy link
Member

sashadev-sky commented Jul 31, 2019

The lock idea looked weird :/ The only reasonable thing I came up with is:

Screen Shot 2019-07-30 at 8 52 06 PM_edited-1

We could remove everything under "license" and write "you are viewing this map in live editing mode". And admin or map owner can click on the green dot to turn off live editing and the box will collapse into something the size of the "write message" area, and say "Live editing mode is off" and dot will turn red. The content under "license" will then show up again.

@ViditChitkara
Copy link
Member Author

That makes sense. I think we should also remove the upload, post, download etc. Functionality as well--actually everything where a user might be able to edit the map. What do you think?

@ViditChitkara
Copy link
Member Author

@jywarren any ideas on this? Should we make it a first-timer-only issue?

@ViditChitkara
Copy link
Member Author

Any updates on this?
Thanks

@ViditChitkara ViditChitkara linked a pull request Aug 13, 2019 that will close this issue
@jywarren
Copy link
Member

hi!

http://publiclab.org/chat could be a good format for a chat popup or embed.

What about a "live editing" switch like this?

image

Would it be on by default? Would it be on permanently for anonymous maps?

@ViditChitkara
Copy link
Member Author

Seems like a good idea! I was thinking of keeping a field in map table "is_editable" or something. I think it should be on by default. The button idea is great though. I'll make a first timer issue for this.
Thanks

@jywarren
Copy link
Member

jywarren commented Aug 14, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants