added leaflet-fullHash object #622
Conversation
added leaflet-fullHash object
|
Thanks for opening this pull request! |
|
Code Climate has analyzed commit d38e602 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #622 +/- ##
===========================================
+ Coverage 42.45% 71.22% +28.77%
===========================================
Files 35 32 -3
Lines 1524 1279 -245
===========================================
+ Hits 647 911 +264
+ Misses 877 368 -509
|
|
@sashadev-sky please review now |
There was a problem hiding this comment.
Great job thank you!!! 😊 PR itself is perfect
Requesting a confirmation on the code from @sagarpreet-chadha (I haven't tested this code locally myself)
|
Hi @konolga, just wanted to ask, if you want any help here? Thanks! |
hi @gauravano , sorry for the late reply. I need help here, I am not familiar with Ruby actually and failed to install it correctly in order to run app. Maybe making such a screenshot can be FTO for someone else? |
|
@konolga no problem! What part was not working for you / is there an error message you can share ? The FTOs are here to help people acclimate not only with Git but also with the Rails setup. We are going through a lot of Rails updates right now to improve the setup experience but for now bear with us! |
|
I tried both, install on my mac and cloud9, stuck with sql, errors are similar, so i am coping here only output from my mac: Then i install mysql and getting this:
|
|
Hi @konolga, don't worry, we are here to help. I found https://stackoverflow.com/questions/51228905/rails-error-installing-mysql2-mysql2-0-3-20 and https://stackoverflow.com/questions/50909928/installing-mysql-2-gem-fails which might work for you. Wanna try? Also, @sashadev-sky uses Mac so she can surely help you with installation if the above StackOverflow threads don't work for you. Thanks! |
|
@konolga the first issue above is that you are using mySQL 8.0.16, but we use 5.7. I made a You want to uninstall the version you are currently using first so there aren't any conflicts - if you have it installed in homebrew this covers that. Community Server you can just google it Also - let me know if you have MacOS Mojave because then you need to do a few other steps https://github.com/publiclab/mapknitter/blob/main/MYSQL.md |
|
yes, i am using Mojave. I've reinstalled mysql 5.7, but still have issues with it:
|
|
@konolga Oh thats awesome! I think that means it worked. The mysql2 error is not OS related.
|
|
yes i do have database.yml. So I updated to Rails 5.2 and got this:
So I deleted Gemfile and copied it again from the source and run
So I delete rails 5.2. Now I guess i should install specifically rails 3.2, but i don't know how. So I think to run
Now time for
so i will be updating packages one by one, this how i spent more than 10 hours (!) trying to run. Guys, please advise or remove me from the issue, i really stuck by updating/removing these packages - and again i never saw Ruby in my eyes before this task |
|
Hi Olga, sorry you have to go through so much trouble.
@sashadev-sky can you run this PR on your system and leave final review?
(Sorry, on mobile right now)
…On Fri, Jun 7, 2019, 12:09 AM Olga Kon ***@***.***> wrote:
yes i do have database.yml.
Also I was getting this error when try bundle exec rake db:setup
> DEPRECATION WARNING: Support for Rails versions before 4.2 is deprecated and will be removed from skylight 2.0. (called from <top (required)> at /Users/olga/Documents/GitHub/mapknitter/config/application.rb:7)
> rake aborted!
So I updated to Rails 5.2 and got this:
LoadError: cannot load such file -- rails/all
So I deleted Gemfile and copied it again from the source and run gem
install bundler , it is successful. Now I run bundle exec rake db:setup
and it says:
Could not find gem 'rails (~> 3.2)' in any of the gem sources listed in
your Gemfile.
So I delete rails 5.2. Now I guess i should install specifically rails
3.2, but i don't know how. So I think to run bundle install, error is:
Bundler could not find compatible versions for gem "activerecord":
In snapshot (Gemfile.lock):
activerecord (= 5.2.3)
In Gemfile:
friendly_id was resolved to 5.2.5, which depends on
activerecord (>= 4.0.0)
rails (~> 3.2) was resolved to 3.2.2.rc1, which depends on
activerecord (= 3.2.2.rc1)
Running bundle update will rebuild your snapshot from scratch, using only
the gems in your Gemfile, which may resolve the conflict.
Now time for bundle update, and new error:
Bundler could not find compatible versions for gem "bundler":
In Gemfile:
rails (> 3.2) was resolved to 3.2.22.5, which depends on
bundler (> 1.0)
Current Bundler version:
bundler (2.0.1)
This Gemfile requires a different version of Bundler.
Perhaps you need to update Bundler by running gem install bundler?
Could not find gem 'bundler (> 1.0)', which is required by gem 'rails (>
3.2)', in any
of the sources.
so i will be updating packages one by one, this how i spent more than 10
hours (!) trying to run.
Guys, please advise or remove me from the issue, i really stuck by
updating/removing these packages - and again i never saw Ruby in my eyes
before this task
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#622?email_source=notifications&email_token=AE7JF5RO4L7XMGQJOCYMW6DPZFKVVA5CNFSM4HOAXQPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXDYY5Y#issuecomment-499616887>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE7JF5WK5MWVCVIEEKQ2VMLPZFKVVANCNFSM4HOAXQPA>
.
|
Line 4 in 03deef1
And I don't remember if I ever did this but this is for mojave too: "Mojave changed the location of header files necessary for compiling C extensions." |
|
@konolga hey I know you're busy, sorry!! I was hoping you could try these out though :) I am trying to get down the installation process for macOS mojave and it would be a great help if you tried it |
|
@sashadev-sky No problem if you can guide me. So I've followed all the steps successfully. Now i am getting this
|
|
@konolga thank you! Instead of $bundle update or $ bundle install you must run Btw the bright side of this is once its setup ur good to go always! |
|
Without errors i managed to do this ( suggested by you versions $bundle/rails were returning errors, not sure why below didn't work at first place)
Now can you please advise how to configurate database?
|
|
This is my development: production: test: Do you have this file in |
|
i just check - yes, i have it. But when i start server by |
|
@konolga yeah completely uninstall and remove that. Try to delete any folders you see related to it in your system too, having these two versions at once can make many problems Do you have @5.7 installed? you can check with if you don't, then just follow the workflow in MYSQL.md if you do, confirm you can run it: Then I think you should be good to go! |
|
My database.yml file is: production: test: I uninstalled both mysqls and reinstalled 5.7. I start
|
|
@konolga woops sorry! I should have indented mine to make it more clear. Does your indent it then run |
|
@rarrunategu1 just a heads up with regard to the dependency work you're doing! Would be good to coordinate just in case. |
|
@jywarren @rarrunategu1 no dependency changes here! @konolga is just helping me fix the The change made in the PR is based on a dependency update that was already merged ( |
|
Hello @sashadev-sky, I'm working on a dependabot for leaflet-fullhash. My update worked out differently than dependabot suggested but it works. I had to bump it using yarn add. Is there a reason it was installed without a version number on the package.json. The package.json says this: |
|
oh, i had indentation, running
|
|
@konolga I rebased your branch so I think that is fixed now as there was an update surrounding |
|
Hi, all - just wanted to say THANK YOU for sticking with this, everyone. I really appreciate how generous you are all being towards one another ❤️. I also had seen the bundler version error and worked around it similarly. Glad to see that i'm not alone on that! |
I confused with pull request and just deleted files from my computer and pulled again and did everything from the scratch (configured config and database files,
I started to set up mysql again, but stuck at this step:
Should we drop it here? Cause installation process now went smoothly and issue is in sql only. |
|
@konolga yes we can drop here. You got me as far as figuring out what commands need to be run on macOS mojave in order to fix the I am going to update the docs now!! Thank you!!! ❤️Obviously if you yourself want to get mySQL up and running I would be happy to keep running through it with you! I will also review this PR now so it can get merged |
|
@sagarpreet-chadha there is a rebase issue here (I will fix that if we want to merge), but I copied the updates @konolga made in her first commit, which matched what was requested in #621, and there is no update to the url. I'm not familiar with this code, can you please advise? The only layer we have on the map is called |
There was a problem hiding this comment.
Hi @sashadev-sky ,
The code seems correct . What is the URL when you open the website first time ?
And what is the URL if you add more layers to the map on the main page ?
Thanks!
|
@sagarpreet-chadha if you can look into it that would be great! I am not sure how to add additional layers and I'm a bit confused where we use the hash object we create. |
|
closing due to being stale! @sagarpreet-chadha |
Fixes #621 Add Leaflet FullHash object for dynamic URL
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!