WIP: Mapknitter Rails Upgrade #669
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
right_aws is no longer maintained, was throwing an error
render :text will be deprecated and poses a security risk
kaustubh-nair
force-pushed
the
development
branch
from
1785ec0
to
0148e7a
Compare
| @uploaded_data = Rack::Test::UploadedFile.new(file_location.to_s, 'demo.png', "image/png") | ||
| @file ||= File.open(File.expand_path(Rails.root + 'test/fixtures/demo.png', __FILE__)) | ||
| @uploaded_data = ActionDispatch::Http::UploadedFile.new(tempfile: @file, filename: File.basename(@file), type: "image/png") | ||
| PaperTrail.enabled = true | ||
| end |
There was a problem hiding this comment.
This change is causing the controller tests to fail
@alaxalves
There was a problem hiding this comment.
I don't understand how it's working in main but not here
There was a problem hiding this comment.
Maybe some new Rails 5 class related thing
|
@alaxalves Image placement has again stopped working here |
|
@kaustubh-nair Can you update |
* Add new system tests and fix minor asset loading * modify test * Add chromedriver to travis * Add sudo * Add dependencies to dockerfile * Properly installing chrome and chromedriver
* WIP action cable setup * basic action cable setup complete * minor change * minor changes * few changes * initial working functionality complete * Refactoring code * Adding Foreman gem * Scheduling Puma and Passenger servers * WIP action cable setup * basic action cable setup complete * minor change * minor changes * few changes * initial working functionality complete * Refactoring code * Adding Foreman gem * Scheduling Puma and Passenger servers * few minor fix * added a few tests * Refactoring connection module * Using strong params in requests * added documentation * added more docs * added tests * Using puma as dependency and correct image controller * added a few tests * a few changes * remove unnecessary render * few test fixes
* few bug fixes * separate editing channels for different maps * test fixes * rubocop fixes
|
I believe we merged rails 5.2 upgrade on another PR...closing this |
This PR tracks the entire upgrade, not only Rails 5.2. We'll need this branch when Rails 6 is shipped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since me and @kaustubh-nair have been using development branch to get our work reviewed and merged faster, we have opened this PR to keep comparing with
mainbranch.Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!