Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dotted line removed on click #692

Merged
merged 1 commit into from
Jun 13, 2019
Merged

Conversation

divyabaid16
Copy link
Contributor

Fixes #691 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

Before:
Selection_174

After:
Selection_173

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@codeclimate
Copy link

codeclimate bot commented Jun 13, 2019

Code Climate has analyzed commit bc0d0f1 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Jun 13, 2019

Codecov Report

Merging #692 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #692   +/-   ##
=====================================
  Coverage   41.2%   41.2%           
=====================================
  Files         34      34           
  Lines       1308    1308           
=====================================
  Hits         539     539           
  Misses       769     769

@divyabaid16
Copy link
Contributor Author

@publiclab/mapknitter-reviewers please review this?
Thanks!

@jywarren jywarren merged commit 4b1c18b into publiclab:main Jun 13, 2019
@jywarren
Copy link
Member

Nice!!!

@divyabaid16 divyabaid16 deleted the dotted-line-bug branch June 24, 2019 05:40
chen-robert pushed a commit to chen-robert/mapknitter that referenced this pull request Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dotted line around html element whenever a link is clicked
2 participants