-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toggle view option for image added in the sidebar #738
Conversation
Code Climate has analyzed commit 7602cab6 and detected 0 issues on this pull request. View more on Code Climate. |
@publiclab/mapknitter-reviewers |
All the tests have passed here. |
7602cab
to
4ccab50
Compare
Looks good to me 👍 |
Hi @divyabaid16, looks great. Please remove the merge conflicts. As a follow-up, we can improve the design from button to icons? Also, how about showing image options in grid view too? @publiclab/mapknitter-reviewers do you think it would look good? Thank you. |
4ccab50
to
ac92fff
Compare
Codecov Report
@@ Coverage Diff @@
## main #738 +/- ##
==========================================
+ Coverage 72.78% 73.15% +0.36%
==========================================
Files 37 37
Lines 1356 1356
==========================================
+ Hits 987 992 +5
+ Misses 369 364 -5
|
@gauravano I have rebased my PR. |
Hey @divyabaid16, CSS is not working well for images of different size Could you try to limit all the columns of sidebar in a single row? Thank you! |
List view is now working fine @gauravano . |
I'm not sure why the test is failing here. Can anyone tell me the reason for this? @publiclab/mapknitter-reviewers |
Hey @divyabaid16, CodeCov is misbehaving a lot on PRs...Could you try rebasing with main? this might fix it. |
5d72fe2
to
ecb7f09
Compare
Hmm, it failed even after rebasing. |
CodeCov expects us to add tests though you did not change any functionality 🤔 |
Should we merge this even though the test is failing? |
Let's ignore CodeCov here for now, we're working on that elsewhere... can you resolve conflicts and then we should be good? Thanks! |
ecb7f09
to
dc0a282
Compare
@jywarren I have resolved the conflicts. This is good to go. |
Nice!!! Great work! |
* Toggle option for image view added * list view correction * Toggle-view
Fixes #724 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
GIF:
rake test
@publiclab/mapknitter-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!