Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing cache path in between builds #794

Merged
merged 1 commit into from
Jul 9, 2019
Merged

Fixing cache path in between builds #794

merged 1 commit into from
Jul 9, 2019

Conversation

alaxalves
Copy link
Member

@alaxalves alaxalves commented Jul 3, 2019

Fixes #0000 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/mapknitter-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@codeclimate
Copy link

codeclimate bot commented Jul 3, 2019

Code Climate has analyzed commit 6b09029 and detected 0 issues on this pull request.

View more on Code Climate.

@alaxalves
Copy link
Member Author

Pushing this to main already since builds are taking too long.

Before caching:
image

After caching:
image

@alaxalves alaxalves changed the title Fixing caching in between builds Fixing cache path in between builds Jul 3, 2019
@codecov
Copy link

codecov bot commented Jul 3, 2019

Codecov Report

Merging #794 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #794   +/-   ##
=======================================
  Coverage   71.41%   71.41%           
=======================================
  Files          35       35           
  Lines        1333     1333           
=======================================
  Hits          952      952           
  Misses        381      381

@alaxalves alaxalves requested a review from jywarren July 3, 2019 18:55
@jywarren
Copy link
Member

jywarren commented Jul 3, 2019

Will this help us with #791 ? Looks great, the speedup is amazing!

@jywarren
Copy link
Member

jywarren commented Jul 5, 2019

Is this ready for merge, in any case? Thank you!

@alaxalves
Copy link
Member Author

alaxalves commented Jul 6, 2019

Is this ready for merge, in any case? Thank you!

Yes it is, but it has nothing to do with #791. #791 I'm working at #803

@jywarren jywarren merged commit 7654b49 into main Jul 9, 2019
@jywarren
Copy link
Member

jywarren commented Jul 9, 2019

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants