Display of an SVG at various places to show if user is banned or active

[grvsachdeva]

Display if someone's been banned or is still active in moderator emails (https://github.com/publiclab/plots2/blob/master/app/views/admin_mailer/notify_node_moderators.html.erb) using the SVG at the above URL so moderators can tell if something's already been moderated without opening a link

SVG preferred: https://gist.github.com/jywarren/ea0523a09f6f8660486b14eeea15de95

[grvsachdeva]

@jywarren, could you mention the flow how it can be useful like with an example. thanks!

[jywarren]

Yes, we could display this in outgoing spam moderation emails, so that even before opening the link to see the page, you could tell if the person had already been banned or spammed; this is often difficult to tell when someone has posted multiple things before being banned for spamming. Thanks!

[jonxuxu]

That's a cool idea! On my localhosted project there's no emails to moderate:

If any of you have a moderator view of this page, a screenshot for design purposes would be appreciated. Alternatively, if there's a way to generate some on local host that would be nice to know too.

[grvsachdeva]

You can generate test users and then play with the things. rails console could help you fasten the user generation process or you can also create the user by going through the normal process.

…

On Mon, Dec 3, 2018 at 3:07 AM Jonathan Xu ***@***.***> wrote: That's a cool idea! On my localhosted project there's no emails to moderate: [image: image] <https://user-images.githubusercontent.com/22998430/49345247-3b72dc80-f650-11e8-8f08-99957b0f38b1.png> If any of you have a moderator view of this page, a screenshot for design purposes would be appreciated. Alternatively, if there's a way to generate some on local host that would be nice to know too. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3338 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AT6S9q9wDkERusbdN40foaeUqYddFV_Vks5u1EgIgaJpZM4WrBsj> .

[jonxuxu]

Oh I see, thanks. I've made a test post and can view it as a moderator on the dashboard as seen below:

However even after changing the moderator email to my own I still don't receive any moderator emails when a post is made.

[grvsachdeva]

Yes, because emails can only be sent in the production. But, I guess a email tab is opened showing the email due to letter_opener ?

…

On Mon, Dec 3, 2018 at 3:57 AM Jonathan Xu ***@***.***> wrote: Oh I see, thanks. I've made a test post and can view it as a moderator on the dashboard as seen below: [image: image] <https://user-images.githubusercontent.com/22998430/49345737-2188c800-f657-11e8-817d-1d22a514b26e.png> However even after changing the moderator email to my own I still don't receive any moderator emails when a post is made. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3338 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AT6S9uQKDbKxd1VzwFJX3A9eHMjEik1Uks5u1FPCgaJpZM4WrBsj> .

[jonxuxu]

Oh okay. How can I open the email tab?

[grvsachdeva]

It opens by default if mail is sent. Try creating a new user and see if new tab(having email i text format) opens for you.

…

On Mon, Dec 3, 2018 at 4:29 AM Jonathan Xu ***@***.***> wrote: Oh okay. How can I open the email tab? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3338 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AT6S9oMrtz2ZE9ymFlohcyhHwtUPz3avks5u1FtYgaJpZM4WrBsj> .

[jonxuxu]

I've created a new account in a separate browser, and I still have no new tab opening up on my browser with the moderator logged in.

[oorjitchowdhary]

@SidharthBansal @gauravano, As @JonathanXu1 is focusing on other important issues.. I'm taking this up.. Hope you don't have a problem @JonathanXu1

[jonxuxu]

Go ahead :)

[oorjitchowdhary]

Thanks a lot Jonathan.. onto it

[oorjitchowdhary]

@publiclab/reviewers Can someone help me with it's conditional..
It should be if node.status == 4 ? or something else

[oorjitchowdhary]

@SidharthBansal I've some doubts for this.. I implemented the conditonal.. Now the email displays the active svg but I wonder how will we ever see the banned svg .. bcoz unless we mark a note spam, we will always see the active banner.. and once we spam a note, we also ban the user so he won't be able to publish any new notes and therefore we won't receive any email with the banned svg..
Please guide me here, if I'm going wrong

[SidharthBansal]

Jeff or Gaurav might help you here. Good luck

…

On Mon, Dec 10, 2018 at 6:51 PM Oorjit Chowdhary ***@***.***> wrote: @SidharthBansal <https://github.com/SidharthBansal> I've some doubts for this.. I implemented the conditonal.. Now the email displays the active svg but I wonder how will we ever see the banned svg .. bcoz unless we mark a note spam, we will always see the active banner.. and once we spam a note, we also ban the user so he won't be able to publish any new notes and therefore we won't receive any email with the banned svg.. Please guide me here, if I'm going wrong — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3338 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AUACQ87PokCKKOoMmdiAWSoDVappqf6Xks5u3l_hgaJpZM4WrBsj> .

[oorjitchowdhary]

@gauravano Please guide me here

[grvsachdeva]

Where's your PR?

[oorjitchowdhary]

I can send a PR.. Wanted to clarify this first.. But I'll submit the PR first then

[SidharthBansal]

You can only continue to work on those prs which will be sent before today's deadline. No PR will be reviewed of it will be sent after today's deadline.

…

On Mon, Dec 10, 2018, 8:50 PM Oorjit Chowdhary ***@***.*** wrote: I can send a PR.. Wanted to clarify this first.. But I'll submit the PR first then — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3338 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AUACQ_bhNlMb0Xkfi9ulPBRvA1nquFdLks5u3nvDgaJpZM4WrBsj> .

[oorjitchowdhary]

Okay.. but I can claim my last task on gci which can be worked upon till Dec 12th .. right?

[grvsachdeva]

I gone through the problem statement again, we want to show svg on email so that moderator could know if it's moderated or not. This would need details from @jywarren to clarify that what change to be brought?

[grvsachdeva]

We send a new email to same thread when the post is moderated. I guess @jywarren is saying we could do some changes in that new email to convey change. That change could be addition of Banned svg with author name. Am I right @jywarren?

[oorjitchowdhary]

So what should I submit for my task.. @gauravano ?
@jywarren Help us here

[grvsachdeva]

For now, in second email add svg according to user status.

[oorjitchowdhary]

So if user.status == 1, ACTIVE svg
else BANNED svg
Am I right?

[grvsachdeva]

yes!

[oorjitchowdhary]

Okay.. PR coming up

[jywarren]

I'm going to close this one, sorry - it ended up not working because GMail caches images... but also, we are modifying the moderation emails in #6246 and this will be less necessary. Thanks!