Sign-up Form Validation message correction

[grvsachdeva]

We are preparing to participate in Google Code-in, and have reserved this issue for participants in GCI - but we'd love to have your help with another one! Please check out https://code.publiclab.org to see more.

Problem

When a user tries to submit an empty sign up form, and also does not check off the recaptcha box, This output is shown:

Solution

Instead, we want all the relevant errors ("field cannot be empty" or so) to be listed along with the failed recaptcha verification.

Each box in this problem is worth some points. We will accept answers that complete one part and not the other, but encourage you to go for all 3. Completion of all three will result in bonus points :)

• fix the create action so that the correct errors show
• fix the error messages themselves as well. If you see below, there are three different errors for email, but only one of them is correct.
• write a test reflecting this fix. Guidelines: the test must fail without your changes, and your changes are what makes it pass.

[grvsachdeva]

Hi, this issue has been opened as a task on GCI dashboard. If you are Google Code-In participant and want to solve this issue, please claim it from Google Code-In website . Thanks!

[sashadev-sky]

@SidharthBansal @gauravano I thought I was cleaning the issue by deleting comments but it makes it look so cluttered still!! Noted

[sashadev-sky]

@SidharthBansal @gauravano we need to add code links here. Since you opened the original issue @gauravano would you be able to figure out where the changes need to be made? The old link you provided is not a valid link anymore!

[SidharthBansal]

Sasha it will be great if you can open up a new issue and close this one. We don't want misunderstanding for Gci candidates.

…

On Fri, Sep 13, 2019, 8:47 AM Sasha Boginsky ***@***.***> wrote: @SidharthBansal <https://github.com/SidharthBansal> @gauravano <https://github.com/gauravano> we need to add code links here. Since you opened the original issue @gauravano <https://github.com/gauravano> would you be able to figure out where the changes need to be made? The old link you provided is not a valid link anymore! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3340?email_source=notifications&email_token=AFAAEQ5ENSLIMLHJ2NUR63LQJMA4XA5CNFSM4FVMEAPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6T26BY#issuecomment-531083015>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFAAEQY37V6SD5367GFHYN3QJMA4XANCNFSM4FVMEAPA> .

[sashadev-sky]

Ok if we want to keep it can either you or @gauravano please re-open with code links :)

[SidharthBansal]

Moved to #6303
@sashadev-sky it will be great if you use hide feature instead of delete feature.
Thanks for help!