unsubscribing responds with "Something went wrong!"

[jywarren]

Something in here: https://github.com/publiclab/plots2/blob/master/app/controllers/subscription_controller.rb#L106-L134

[jywarren]

OK, this is solved... i was briefly confused by the fact that set_following in subscription_controller returns a boolean for the state of following, rather than for the success of following/unfollowing. I left that as is, but added a kinda janky error message throwing if it fails. Is it worth making a stronger convention for returning a boolean? It's def. a style thing, and shouldn't cause too much more trouble.

[btbonval]

I did that for idempotence.

If you click "set_following :true" four times in a row, "set_following
:false" three times, and then "set_following :true" again, but the server
hasn't finished processing the first call, these things can be submit out
of order.

Returning a boolean indicates which function was just performed and what
the current state is, which is submit back to the client's browser as a
form of confirmation so the client javascript can update.

If there's an error, then error handling techniques would be more
appropriate than returning a false boolean.

On Sun, May 4, 2014 at 5:32 PM, Jeffrey Warren [email protected]:

OK, this is solved... i was briefly confused by the fact that
set_following in subscription_controller returns a boolean for the _state_of following, rather than for the
success of following/unfollowing. I left that as is, but added a kinda
janky error message throwing if it fails. Is it worth making a stronger
convention for returning a boolean? It's def. a style thing, and shouldn't
cause too much more trouble.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/41#issuecomment-42145876
.

[jywarren]

That makes sense, thanks for explaining. I guess I'm not that used to doing proper error handling beyond checking for the success of something and flash[:error]ing a message. Should brush up on error handling in Rails... it ought to make my code a bit more terse as well.

[btbonval]

I'm still making my way through the Ruby guide. I finally understand wtf is
with "blocks" like { |thing| thing.stuff blat }, which is a common theme
in Ruby. Definitely good to know.

Anyway, this is a few chapters ahead of where I'm at:
http://ruby-doc.com/docs/ProgrammingRuby/html/tut_exceptions.html

On Mon, May 5, 2014 at 11:58 AM, Jeffrey Warren [email protected]:

That makes sense, thanks for explaining. I guess I'm not that used to
doing proper error handling beyond checking for the success of something
and flash[:error]ing a message. Should brush up on error handling in
Rails... it ought to make my code a bit more terse as well.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/41#issuecomment-42203608
.